Fix edge-case crash on invalid input file

Author: niranjan94

app/src/main/kotlin/com/njlabs/showjava/activities/decompiler/DecompilerActivity.kt

@@ -126,6 +126,13 @@ class DecompilerActivity : BaseActivity() {
             }
                 .subscribeOn(Schedulers.io())
                 .observeOn(AndroidSchedulers.mainThread())
+                .onErrorReturn {
+                    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
+                        resources.getDrawable(R.drawable.ic_list_generic, null)
+                    } else {
+                        resources.getDrawable(R.drawable.ic_list_generic)
+                    }
+                }
                 .subscribe { itemIcon.setImageDrawable(it) }
         )
 
@@ -134,7 +141,12 @@ class DecompilerActivity : BaseActivity() {
 
     private fun loadPackageInfoFromIntent() {
         if (intent.dataString.isNullOrEmpty()) {
-            packageInfo = intent.getParcelableExtra("packageInfo")
+            if (intent.hasExtra("packageInfo")) {
+                packageInfo = intent.getParcelableExtra("packageInfo")
+            } else {
+                Toast.makeText(context, R.string.errorLoadingInputFile, Toast.LENGTH_SHORT).show()
+                finish()
+            }
         } else {
             val info = PackageInfo.fromFile(
                 context,

app/src/main/res/values/strings.xml

@@ -172,5 +172,6 @@
     <string name="useCustomFontSummary">Choose between lato or system default font</string>
     <string name="userInterface">User interface</string>
     <string name="instanceId">(ID: <xliff:g example="abc134_GTF" id="instanceIdString">%1$s</xliff:g>)</string>
-    <string name="onlyPositiveIntegersAllowed">Only positive integers are allowed.</string>
+    <string name="onlyPositiveIntegersAllowed">Only positive integers are allowed</string>
+    <string name="errorLoadingInputFile">Error loading input file</string>
 </resources>