Skip to content

Commit 1a2dd1a

Browse files
nirgn975Nir Galon
authored andcommitted
fix: fix accessibility issues
1 parent 652b639 commit 1a2dd1a

File tree

6 files changed

+15
-10
lines changed

6 files changed

+15
-10
lines changed

assets/javascript/main.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ document.addEventListener("DOMContentLoaded", function(event) {
7777
<p>${editedPostText}</p>
7878
</div>
7979
<div class="uk-card-footer">
80-
<a href="${entity.getElementsByTagName("link")[0].textContent}" target="_blank" class="uk-button uk-button-text">Go to Post</a>
80+
<a href="${entity.getElementsByTagName("link")[0].textContent}" target="_blank" class="uk-button uk-button-text" rel="noreferrer">Go to Post</a>
8181
</div>
8282
</div>
8383
</div>
@@ -103,8 +103,9 @@ document.addEventListener("DOMContentLoaded", function(event) {
103103
</div>
104104
</div>
105105
<div class="uk-card-media-top">
106-
<a href="${repo.value.url}" target="_blank">
107-
<img src="img/projects/${repo.url}.webp">
106+
<a href="${repo.value.url}" target="_blank" rel="noreferrer">
107+
<p style="display: none">A GitHub project hero cover</p>
108+
<img src="img/projects/${repo.url}.webp" alt="A GitHub project hero cover">
108109
</a>
109110
</div>
110111
<div class="uk-card-body">

exampleSite/config.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
11
baseURL = "https://example.com/"
22
languageCode = "en-us"
3+
34
title = "DevRes"
45
theme = "devRes"
56

67
# themes directory - delete it on our own hugo website.
78
themesDir = "../.."
89

910
[params]
11+
description = "The best theme for developers resume"
12+
author = "nirgn975"
13+
1014
[params.light]
1115
background = "#E0E0E0"
1216
text = "#333333"

layouts/partials/_banner.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
</div>
1010
<div class="links">
1111
{{ range .Site.Data.content.banner.links }}
12-
<a href="{{ .url }}" target="_blank">
12+
<a href="{{ .url }}" target="_blank" rel="noreferrer">
1313
<i class="{{ .icon }}"></i>{{ .text }}
1414
</a>
1515
<br>
@@ -25,7 +25,7 @@
2525
</button>
2626

2727
<!-- This is an anchor toggling the off-canvas -->
28-
<a href="#mobile-banner" uk-toggle></a>
28+
<a href="#mobile-banner" uk-toggle><p style="display: none">Mobile toggle button</p></a>
2929

3030
<!-- This is the off-canvas -->
3131
<div id="mobile-banner" uk-offcanvas>
@@ -37,7 +37,7 @@
3737
</div>
3838
<div class="links">
3939
{{ range .Site.Data.content.banner.links }}
40-
<a href="{{ .url }}" target="_blank">
40+
<a href="{{ .url }}" target="_blank" rel="noreferrer">
4141
<i class="{{ .icon }}"></i>{{ .text }}
4242
</a>
4343
<br>

layouts/partials/_education.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ <h2>Education</h2>
1111
<span class="date">{{ .timeStart }} - {{ .timeEnd }}</span>
1212
<h3>
1313
{{ .course }} @
14-
<a href="{{ .schoolUrl | safeHTML }}" target="_blank">{{ .schoolName }}</a>
14+
<a href="{{ .schoolUrl | safeHTML }}" target="_blank" rel="noreferrer">{{ .schoolName }}</a>
1515
</h3>
1616
<p>
1717
{{ .text | safeHTML }}

layouts/partials/_talks.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ <h3 class="uk-card-title">{{ .title }}</h3>
1616
<p>
1717
<span>{{ .date }}</span> |
1818
<span>
19-
<a href="{{ .meetupUrl }}" target="_blank"> Meetpup Page</a> |
19+
<a href="{{ .meetupUrl }}" target="_blank" rel="noreferrer"> Meetpup Page</a> |
2020
</span>
2121
<span>
22-
<a href="{{ .downloadLink }}" target="_blank"> Download</a>
22+
<a href="{{ .downloadLink }}" target="_blank" rel="noreferrer"> Download</a>
2323
</span>
2424
</p>
2525
</div>

layouts/partials/_work.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ <h2>Work</h2>
1111
<span class="date">{{ .timeStart }} - {{ .timeEnd }}</span>
1212
<h3>
1313
{{ .position }} @
14-
<a href="{{ .employerUrl | safeHTML }}" target="_blank">{{ .employerName }}</a>
14+
<a href="{{ .employerUrl | safeHTML }}" target="_blank" rel="noreferrer">{{ .employerName }}</a>
1515
</h3>
1616
<p>
1717
{{ .text | safeHTML }}

0 commit comments

Comments
 (0)