Skip to content

Commit d68ab35

Browse files
authored
fix: fix best practices lighthouse optimization (#13)
fix #12
1 parent b7f0ab2 commit d68ab35

File tree

7 files changed

+18
-14
lines changed

7 files changed

+18
-14
lines changed

assets/scss/main.scss

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
:root {
22
--color-background: {{ .Site.Params.light.background | default "#E0E0E0" }};
33
--color-text: {{ .Site.Params.light.text | default "#333333" }};
4-
--color-text-hover: {{ .Site.Params.light.textHover | default "#1e70bf" }};
4+
--color-text-hover: {{ .Site.Params.light.textHover | default "#0a62b9" }};
55
--color-border: {{ .Site.Params.light.border | default "#999999" }};
66
--color-header-background: {{ .Site.Params.light.headerBackground | default "#ffffff" }};
77
}
88

99
[data-theme="dark"] {
1010
--color-background: {{ .Site.Params.dark.background | default "#303030" }};
1111
--color-text: {{ .Site.Params.dark.text | default "#B3B3B3" }};
12-
--color-text-hover: {{ .Site.Params.dark.textHover | default "#bdebfc" }};
12+
--color-text-hover: {{ .Site.Params.dark.textHover | default "#0a62b9" }};
1313
--color-border: {{ .Site.Params.dark.colorBorder | default "#666666" }};
1414
--color-header-background: {{ .Site.Params.dark.headerBackground | default "#424242" }};
1515
}
@@ -45,8 +45,14 @@ span {
4545
color: var(--color-text);
4646
}
4747

48+
a {
49+
color: var(--color-text-hover);
50+
text-decoration: none;
51+
}
52+
4853
a:hover {
4954
color: var(--color-text-hover);
55+
text-decoration: none !important;
5056
}
5157

5258
div.uk-container {
@@ -118,10 +124,6 @@ span.category-header {
118124
margin-right: .5rem;
119125
}
120126
}
121-
122-
a:hover {
123-
color: var(--color-text-hover);
124-
}
125127
}
126128

127129
/*

exampleSite/config.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@ themesDir = "../.."
1414
[params.light]
1515
background = "#E0E0E0"
1616
text = "#333333"
17-
textHover = "#1e70bf"
17+
textHover = "#0a62b9"
1818
border = "#999999"
1919
headerBackground = "#ffffff"
2020

2121
[params.dark]
2222
background = "#303030"
2323
text = "#B3B3B3"
24-
textHover = "#bdebfc"
24+
textHover = "#0a62b9"
2525
border = "#666666"
2626
headerBackground = "#424242"
2727

exampleSite/data/content.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ education:
6565
list:
6666
enable: True
6767
items:
68-
- text: "The <a href='https://www.udacity.com/course/deep-learning-nanodegree-foundation--nd101' target='_blank'>program syllabus</a> include: Neural Networks, Convolutional Neural Networks, Recurrent Neural Networks, Generative Adversarial Networks"
69-
- text: The 5 projects I built during the program - <a href="https://github.com/nirgn975/DLND" target="_blank">GitHub</a>
68+
- text: "The <a href='https://www.udacity.com/course/deep-learning-nanodegree-foundation--nd101' target='_blank' rel='noreferrer'>program syllabus</a> include: Neural Networks, Convolutional Neural Networks, Recurrent Neural Networks, Generative Adversarial Networks"
69+
- text: The 5 projects I built during the program - <a href="https://github.com/nirgn975/DLND" target="_blank" rel='noreferrer'>GitHub</a>
7070
- course: Bachelor of Science (BSc) in Computer Science
7171
schoolName: MIT - Massachusetts Institute of Technology
7272
schoolUrl: https://www.linkedin.com/school/mit/

exampleSite/static/icons/browserconfig.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
<browserconfig>
33
<msapplication>
44
<tile>
5-
<square150x150logo src="/android-chrome-192x192.png"/>
6-
<TileColor>#1e87f0</TileColor>
5+
<square150x150logo src="/icons/android-chrome-192x192.png"/>
6+
<TileColor>#0c67c1</TileColor>
77
</tile>
88
</msapplication>
99
</browserconfig>

exampleSite/static/icons/site.webmanifest

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
"name": "devRes",
33
"short_name": "devRes",
44
"icons": [{
5-
"src": "/android-chrome-192x192.png",
5+
"src": "/icons/android-chrome-192x192.png",
66
"sizes": "192x192",
77
"type": "image/png"
88
}, {
9-
"src": "/android-chrome-512x512.png",
9+
"src": "/icons/android-chrome-512x512.png",
1010
"sizes": "512x512",
1111
"type": "image/png"
1212
}],
4.25 KB
Loading

layouts/partials/head.html

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
<meta charset="utf-8">
33
<title>{{ .Site.Title }}</title>
44

5+
<link rel="preconnect" href="https://cdn.jsdelivr.net">
6+
57
{{ "<!-- mobile responsive meta -->" | safeHTML }}
68
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=5">
79
<meta name="description" content="{{ with .Description }}{{ . }}{{ else }}{{ with site.Params.description }}{{ . }}{{ end }}{{ end }}">

0 commit comments

Comments
 (0)