fix(qa): remove auto-fix from qa:all to prevent unstaged changes in hooks

Problem: Running qa:fix inside qa:all during git hooks causes auto-fixes
without staging changes, leading to commits without the fixes.

Solution:
- qa:all now validation-only (no code modification)
- Created qa:all:fix for manual workflow (fix → validate)
- Updated hooks and CI docs to clarify validation-only behavior

Rationale:
- Git hooks should validate, not modify uncommitted code
- CI should validate, not modify code (anti-pattern)
- Manual workflow: run qa:all:fix, review changes, stage, commit

Files:
- .cursor/commands/qa/Taskfile.yml - Split validation from fixing
- .github/workflows/ci.yml - Updated docs
- .husky/pre-commit - Clarified validation-only
- .husky/pre-push - Clarified validation-only

Author: nirukk52

.cursor/commands/qa/Taskfile.yml

@@ -110,13 +110,12 @@ tasks:
       - cd ../../../frontend && bun run test:e2e:ui
     silent: false
 
-  # Complete QA suite (THE definitive quality check)
+  # Validation-only QA suite (for git hooks and CI)
+  # Does NOT modify code - only validates
   all:
-    desc: "Complete QA suite (fix + rules + smoke + lint + typecheck + unit + e2e)"
+    desc: "Validation QA suite (rules + smoke + lint + typecheck + unit + e2e)"
     cmds:
-      - echo "🎯 Running comprehensive QA suite..."
-      - echo ""
-      - task: fix
+      - echo "🎯 Running validation QA suite (no auto-fix)..."
       - echo ""
       - task: rules:check
       - echo ""
@@ -130,7 +129,22 @@ tasks:
       - echo ""
       - task: e2e
       - echo ""
-      - echo "🎉 All QA checks passed!"
+      - echo "🎉 All validation checks passed!"
+    silent: false
+  
+  # Complete QA workflow (fix THEN validate)
+  # Use this manually before committing
+  all:fix:
+    desc: "Complete workflow - auto-fix then validate (manual use only)"
+    cmds:
+      - echo "Step 1 - Auto-fixing issues..."
+      - task: fix
+      - echo ""
+      - echo "Auto-fix complete. Review changes with git diff"
+      - echo "Stage changes with git add . if satisfied"
+      - echo ""
+      - echo "Step 2 - Running validation suite..."
+      - task: all
     silent: false
 
   # Appium (mobile testing)

.github/workflows/ci.yml

@@ -102,14 +102,18 @@ jobs:
 # MIRRORS LOCAL: Exact same command developers run locally
 # DRY: No duplication - all logic in .cursor/commands/qa/Taskfile.yml
 #
-# What `task qa:all` runs:
-# 1. qa:fix       - Auto-fix linting/formatting
-# 2. qa:rules     - Validate founder rules (no console.log, no any, American spelling)
-# 3. qa:smoke     - Health checks (backend + frontend)
-# 4. qa:lint      - Linting (backend + frontend)
-# 5. qa:typecheck - TypeScript validation (frontend)
-# 6. qa:unit      - Unit tests (backend only - encore test)
-# 7. qa:e2e       - E2E tests (frontend Playwright)
+# What `task qa:all` runs (VALIDATION ONLY - no code modification):
+# 1. qa:rules     - Validate founder rules (no console.log, no any, American spelling)
+# 2. qa:smoke     - Health checks (backend + frontend)
+# 3. qa:lint      - Linting (backend + frontend)
+# 4. qa:typecheck - TypeScript validation (frontend)
+# 5. qa:unit      - Unit tests (backend only - encore test)
+# 6. qa:e2e       - E2E tests (frontend Playwright)
+#
+# Note: Auto-fix (qa:fix) is intentionally excluded from qa:all
+# - Git hooks should validate, not modify uncommitted code
+# - CI should validate, not modify code (anti-pattern)
+# - Manual workflow: `task qa:all:fix` (fix → validate) before committing
 #
 # Dependencies:
 # - go-task      - Taskfile runner

.husky/pre-commit

@@ -1,16 +1,21 @@
 #!/bin/sh
 # Husky pre-commit hook
-# Comprehensive QA suite BEFORE commit (coding agent safety)
+# Validation QA suite BEFORE commit (coding agent safety)
 # 
 # WHY REDUNDANT: Coding agents can bypass guards and commit directly.
 # Running qa:all here ensures quality checks at EVERY commit.
+#
+# IMPORTANT: qa:all is VALIDATION ONLY (does not modify code)
+# To auto-fix before committing, run: cd .cursor && task qa:all:fix
+# This will fix issues, show you the changes, and let you stage them.
 
-echo "🛠️ Running comprehensive QA suite before commit..."
+echo "🛠️ Running validation QA suite before commit..."
+echo "   (Validation only - does not modify code)"
 echo "   (Redundant with pre-push for coding agent safety)"
 echo ""
 (cd .cursor && task qa:all) || exit 1
 
 echo ""
-echo "✅ Pre-commit checks passed!"
+echo "✅ Pre-commit validation passed!"
 
 

.husky/pre-push

@@ -1,11 +1,16 @@
 #!/bin/sh
 # Husky pre-push hook
-# Comprehensive QA suite + merge commit check
+# Validation QA suite + merge commit check
 # 
 # WHY REDUNDANT: Coding agents can bypass pre-commit and push directly.
 # Running qa:all here ensures quality checks at EVERY push.
+#
+# IMPORTANT: qa:all is VALIDATION ONLY (does not modify code)
+# To auto-fix before pushing, run: cd .cursor && task qa:all:fix
+# This will fix issues, show you the changes, and let you stage them.
 
-echo "🛠️ Running comprehensive QA suite before push..."
+echo "🛠️ Running validation QA suite before push..."
+echo "   (Validation only - does not modify code)"
 echo "   (Redundant with pre-commit for coding agent safety)"
 echo ""
 (cd .cursor && task qa:all) || exit 1