Refactor testing commands in Taskfile.yml for improved clarity and organization. Consolidate smoke tests and add new linting, type checking, and unit test tasks in qa/Taskfile.yml. Update founder_rules.mdc to include critical guidelines for Git operations.

Author: nirukk52

.cursor/commands/founder/Taskfile.yml

@@ -67,25 +67,3 @@ tasks:
       - cd ../../backend && encore db reset
       - echo "✅ Database reset complete"
     silent: false
-
-  # Testing
-  testing:smoke:
-    desc: "Run all smoke tests"
-    cmds:
-      - task: qa:smoke:backend
-      - task: qa:smoke:frontend
-    silent: false
-
-  testing:backend:
-    desc: "Run backend tests"
-    cmds:
-      - echo "🧪 Running backend tests..."
-      - cd ../../backend && encore test
-    silent: false
-
-  testing:frontend:
-    desc: "Run frontend tests"
-    cmds:
-      - echo "🧪 Running frontend tests..."
-      - cd ../../frontend && bun test
-    silent: false

.cursor/commands/qa/Taskfile.yml

@@ -1,34 +1,128 @@
 version: '3'
 
 # QA commands
-# Testing and quality assurance tasks
+# Consolidated testing and quality assurance tasks
 
 tasks:
+  # Smoke tests (parallel health checks)
+  smoke:
+    desc: "Health checks for all services"
+    cmds:
+      - echo "🧪 Running smoke tests..."
+      - |
+        BACKEND_FAIL=0
+        FRONTEND_FAIL=0
+        
+        curl -sf http://localhost:${BACKEND_PORT:-4000}/health > /dev/null && echo "✅ Backend healthy" || { echo "❌ Backend smoke test failed"; BACKEND_FAIL=1; } &
+        PID_BACKEND=$!
+        
+        curl -sf http://localhost:${FRONTEND_PORT:-5173} > /dev/null && echo "✅ Frontend healthy" || { echo "❌ Frontend smoke test failed"; FRONTEND_FAIL=1; } &
+        PID_FRONTEND=$!
+        
+        wait $PID_BACKEND || BACKEND_FAIL=1
+        wait $PID_FRONTEND || FRONTEND_FAIL=1
+        
+        if [ $BACKEND_FAIL -eq 0 ] && [ $FRONTEND_FAIL -eq 0 ]; then
+          echo "✅ All smoke tests passed"
+          exit 0
+        else
+          echo "❌ Some smoke tests failed"
+          exit 1
+        fi
+    silent: false
+
   smoke:backend:
-    desc: "Run backend smoke tests"
+    desc: "Backend health check only"
     cmds:
-      - echo "🧪 Running backend smoke tests..."
-      - echo "   Testing backend health endpoint..."
+      - echo "🧪 Testing backend health..."
       - curl -f http://localhost:${BACKEND_PORT:-4000}/health || (echo "❌ Backend smoke test failed" && exit 1)
-      - echo "✅ Backend smoke tests passed"
+      - echo "✅ Backend smoke test passed"
     silent: false
 
   smoke:frontend:
-    desc: "Run frontend smoke tests"
+    desc: "Frontend availability check only"
     cmds:
-      - echo "🧪 Running frontend smoke tests..."
-      - echo "   Testing frontend accessibility..."
+      - echo "🧪 Testing frontend availability..."
       - curl -f http://localhost:${FRONTEND_PORT:-5173} > /dev/null || (echo "❌ Frontend smoke test failed" && exit 1)
-      - echo "✅ Frontend smoke tests passed"
+      - echo "✅ Frontend smoke test passed"
+    silent: false
+
+  # Static analysis
+  lint:
+    desc: "Lint both services"
+    cmds:
+      - echo "🔍 Linting backend..."
+      - cd ../../../backend && bunx biome lint .
+      - echo "🔍 Linting frontend..."
+      - cd ../../../frontend && bunx biome lint .
+      - echo "✅ Linting complete"
+    silent: false
+
+  typecheck:
+    desc: "TypeScript checking for both services"
+    cmds:
+      - echo "🔍 Type checking frontend..."
+      - cd ../../../frontend && bun run check
+      - echo "✅ Frontend types valid"
+    silent: false
+
+  # Unit tests
+  unit:backend:
+    desc: "Backend unit tests"
+    cmds:
+      - echo "🧪 Running backend unit tests..."
+      - cd ../../../backend && encore test
+    silent: false
+
+  unit:frontend:
+    desc: "Frontend unit tests"
+    cmds:
+      - echo "⚠️  No frontend unit tests configured yet"
+      - echo "   Frontend uses Playwright for E2E tests (use qa:e2e)"
+    silent: false
+
+  unit:
+    desc: "All unit tests (backend only, frontend has no unit tests)"
+    cmds:
+      - task: unit:backend
+      - echo "Note - Frontend has no unit tests (uses E2E tests instead)"
+    silent: false
+
+  # E2E tests
+  e2e:
+    desc: "Frontend E2E tests (headless)"
+    cmds:
+      - echo "🧪 Running E2E tests..."
+      - cd ../../../frontend && bun run test:e2e
+    silent: false
+
+  e2e:headed:
+    desc: "Frontend E2E tests (headed mode)"
+    cmds:
+      - echo "🧪 Running E2E tests (headed)..."
+      - cd ../../../frontend && bun run test:e2e:headed
     silent: false
 
-  smoke:all:
-    desc: "Run all smoke tests"
+  e2e:ui:
+    desc: "Playwright UI mode"
     cmds:
-      - task: smoke:backend
-      - task: smoke:frontend
+      - echo "🎭 Opening Playwright UI..."
+      - cd ../../../frontend && bun run test:e2e:ui
     silent: false
 
+  # Complete test suite
+  all:
+    desc: "Complete test suite (smoke + lint + typecheck + unit + e2e)"
+    cmds:
+      - task: smoke
+      - task: lint
+      - task: typecheck
+      - task: unit
+      - task: e2e
+      - echo "🎉 All tests passed!"
+    silent: false
+
+  # Appium (mobile testing)
   appium:start:
     desc: "Start Appium server"
     cmds:
@@ -44,10 +138,3 @@ tasks:
       - lsof -ti:${APPIUM_PORT:-4723} 2>/dev/null | xargs kill -9 2>/dev/null || true
       - echo "✅ Appium server stopped"
     silent: false
-
-  e2e:
-    desc: "Run end-to-end tests"
-    cmds:
-      - echo "🧪 Running E2E tests..."
-      - cd ../../backend && bun run test:e2e
-    silent: false

.cursor/rules/founder_rules.mdc

@@ -31,8 +31,9 @@ description: "Non-negotiable development standards for ScreenGraph. Enforces arc
 15. [Single Environment Execution](#single-environment-execution)
 16. [Worktree Usage](#worktree-usage)
 17. [Standard Ports](#standard-ports)
-18. [Cursor Modes](#cursor-dropdown-modes)
-19. [Enforcement Rules](#enforcement-what-agents-cannot-do)
+18. [Git Operations](#git-operations)
+19. [Cursor Modes](#cursor-dropdown-modes)
+20. [Enforcement Rules](#enforcement-what-agents-cannot-do)
 
 ---
 
@@ -341,6 +342,23 @@ cd frontend && bun run dev # Service-specific when needed
 - Scripts `./automation/scripts/dev-backend.sh` and `./automation/scripts/dev-frontend.sh` respect `.env` values.
 - Husky/CI always start services on the standard ports defined above.
 
+### Git Operations
+
+**CRITICAL: Git commits and pushes require explicit founder approval**
+
+- ❌ **NEVER commit changes** unless the founder explicitly says "commit" or "commit this" in the prompt
+- ❌ **NEVER push changes** unless the founder explicitly says "push" or "push this" in the prompt
+- ❌ **NEVER run `git commit`** proactively, even if you think the work is complete
+- ❌ **NEVER stage files** (`git add`) unless explicitly requested
+
+**Rationale:**
+- The founder controls when code is committed to history
+- Commits are permanent and must be intentional
+- AI agents should implement changes, not decide when they're "done"
+- Pre-commit hooks may have side effects that need manual oversight
+
+**Violation:** If you commit or push without explicit founder approval, you are being too proactive and overstepping boundaries.
+
 ---
 
-**Last Updated**: 2025-11-07
+**Last Updated**: 2025-11-09

package.json

@@ -12,11 +12,12 @@
     "dev:backend": "BACKEND_PORT=${BACKEND_PORT:-4000} turbo run dev --filter=screengraph-backend",
     "dev:frontend": "FRONTEND_PORT=${FRONTEND_PORT:-5173} turbo run dev --filter=screengraph-frontend",
     "task": "cd .cursor && task",
-    "qa:smoke": "cd .cursor && task qa:smoke:all",
-    "qa:smoke:frontend": "cd .cursor && task qa:smoke:frontend",
-    "qa:smoke:backend": "cd .cursor && task qa:smoke:backend",
-    "lint": "cd .cursor && task frontend:lint",
-    "typecheck": "cd .cursor && task frontend:typecheck",
+    "qa": "cd .cursor && task qa:all",
+    "qa:smoke": "cd .cursor && task qa:smoke",
+    "qa:lint": "cd .cursor && task qa:lint",
+    "qa:typecheck": "cd .cursor && task qa:typecheck",
+    "qa:unit": "cd .cursor && task qa:unit",
+    "qa:e2e": "cd .cursor && task qa:e2e",
     "test:e2e": "turbo run test:e2e --filter=screengraph-frontend",
     "test:e2e:headed": "turbo run test:e2e:headed --filter=screengraph-frontend",
     "test:e2e:ci": "turbo run test:e2e:ci --filter=screengraph-frontend",