Skip to content

Commit f268771

Browse files
committed
Record constructors bacame to take only keywords
See also nirum-lang/nirum#165
1 parent 8d36461 commit f268771

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

tests/conftest.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ def fx_record_type():
2020

2121
@fixture
2222
def fx_point(fx_record_type, fx_unboxed_type):
23-
return fx_record_type(fx_unboxed_type(3.14), fx_unboxed_type(1.592))
23+
return fx_record_type(left=fx_unboxed_type(3.14),
24+
top=fx_unboxed_type(1.592))
2425

2526

2627
@fixture
@@ -35,7 +36,7 @@ def fx_rectangle_type():
3536

3637
@fixture
3738
def fx_rectangle(fx_rectangle_type, fx_point):
38-
return fx_rectangle_type(fx_point, fx_point)
39+
return fx_rectangle_type(upper_left=fx_point, lower_right=fx_point)
3940

4041

4142
@fixture

tests/serialize_test.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@ def test_serialize_record_type(fx_point):
2929

3030
def test_serialize_union_type(fx_point, fx_offset, fx_circle_type,
3131
fx_rectangle_type):
32-
circle = fx_circle_type(fx_point, fx_offset)
32+
circle = fx_circle_type(origin=fx_point, radius=fx_offset)
3333
s = {
3434
'_type': 'shape', '_tag': 'circle',
3535
'origin': serialize_record_type(fx_point),
3636
'radius': serialize_unboxed_type(fx_offset)
3737
}
3838
assert serialize_union_type(circle) == s
39-
rectangle = fx_rectangle_type(fx_point, fx_point)
39+
rectangle = fx_rectangle_type(upper_left=fx_point, lower_right=fx_point)
4040
s = {
4141
'_type': 'shape', '_tag': 'rectangle',
4242
'upper_left': serialize_record_type(fx_point),
@@ -93,8 +93,9 @@ def test_serialize_meta_set(d, expect):
9393

9494

9595
def test_serialize_meta_list(fx_record_type, fx_unboxed_type, fx_offset):
96-
record = fx_record_type(fx_offset, fx_offset)
97-
record2 = fx_record_type(fx_unboxed_type(1.1), fx_unboxed_type(1.2))
96+
record = fx_record_type(left=fx_offset, top=fx_offset)
97+
record2 = fx_record_type(left=fx_unboxed_type(1.1),
98+
top=fx_unboxed_type(1.2))
9899
serialize_result = serialize_meta([record, record2])
99100
assert serialize_result == [
100101
{'_type': 'point', 'x': 1.2, 'top': 1.2},
@@ -105,8 +106,9 @@ def test_serialize_meta_list(fx_record_type, fx_unboxed_type, fx_offset):
105106

106107
def test_serialize_meta_set_of_record(fx_record_type, fx_unboxed_type,
107108
fx_offset):
108-
record = fx_record_type(fx_offset, fx_offset)
109-
record2 = fx_record_type(fx_unboxed_type(1.1), fx_unboxed_type(1.2))
109+
record = fx_record_type(left=fx_offset, top=fx_offset)
110+
record2 = fx_record_type(left=fx_unboxed_type(1.1),
111+
top=fx_unboxed_type(1.2))
110112
serialize_result = serialize_meta({record, record2})
111113
assert record.__nirum_serialize__() in serialize_result
112114
assert record2.__nirum_serialize__() in serialize_result

0 commit comments

Comments
 (0)