fix: correct import ordering and validate NITRIC_HOSTNAME

- Move env import to correct alphabetical position (between batch
  and gateway)
- Reject NITRIC_HOSTNAME values containing URL-unsafe characters
  (/?#, newlines, whitespace) at startup to prevent malformed URLs

Author: tom-groves

pkg/cloud/cloud.go

@@ -27,6 +27,7 @@ import (
 
 	"github.com/nitrictech/cli/pkg/cloud/apis"
 	"github.com/nitrictech/cli/pkg/cloud/batch"
+	"github.com/nitrictech/cli/pkg/cloud/env"
 	"github.com/nitrictech/cli/pkg/cloud/gateway"
 	"github.com/nitrictech/cli/pkg/cloud/http"
 	"github.com/nitrictech/cli/pkg/cloud/keyvalue"
@@ -36,7 +37,6 @@ import (
 	"github.com/nitrictech/cli/pkg/cloud/secrets"
 	"github.com/nitrictech/cli/pkg/cloud/sql"
 	"github.com/nitrictech/cli/pkg/cloud/storage"
-	"github.com/nitrictech/cli/pkg/cloud/env"
 	"github.com/nitrictech/cli/pkg/cloud/topics"
 	"github.com/nitrictech/cli/pkg/cloud/websites"
 	"github.com/nitrictech/cli/pkg/cloud/websockets"
@@ -259,6 +259,11 @@ type LocalCloudOptions struct {
 func New(projectName string, opts LocalCloudOptions) (*LocalCloud, error) {
 	hostname := env.NITRIC_HOSTNAME.String()
 
+	// Reject hostnames containing characters that would produce malformed URLs
+	if strings.ContainsAny(hostname, "/?#\r\n \t") {
+		return nil, fmt.Errorf("NITRIC_HOSTNAME contains invalid characters: %q", hostname)
+	}
+
 	// Bracket IPv6 literals for use in URLs (RFC 3986)
 	if strings.Contains(hostname, ":") && !strings.HasPrefix(hostname, "[") {
 		hostname = "[" + hostname + "]"