From 3082f828badeb455386685167c928c444058e2bc Mon Sep 17 00:00:00 2001 From: Tim Holm Date: Thu, 22 Aug 2024 13:08:49 +1000 Subject: [PATCH 1/3] docs: Update GCP configuration reference. --- src/pages/reference/providers/gcp/configuration.mdx | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/pages/reference/providers/gcp/configuration.mdx b/src/pages/reference/providers/gcp/configuration.mdx index 828b3f9de..a97b86e1c 100644 --- a/src/pages/reference/providers/gcp/configuration.mdx +++ b/src/pages/reference/providers/gcp/configuration.mdx @@ -47,10 +47,18 @@ config: default: # configure services to deploy to Google Cloud Run cloudrun: + # set 1 CPU + # See cloudrun configuration docs here: + # https://cloud.google.com/run/docs/configuring + cpus: 1 # set 512MB of RAM # See cloudrun configuration docs here: # https://cloud.google.com/run/docs/configuring/memory-limits memory: 512 + # set 0 GPUs + # See cloudrun configuration docs here: + # https://cloud.google.com/run/docs/configuring + gpus: 0 # set a timeout of 15 seconds # https://cloud.google.com/run/docs/configuring/request-timeout timeout: 15 From 04b30036fc3cdda993fed2b426acc7674beafa51 Mon Sep 17 00:00:00 2001 From: Tim Holm Date: Thu, 22 Aug 2024 13:33:17 +1000 Subject: [PATCH 2/3] add provider version number. --- src/pages/reference/providers/gcp/configuration.mdx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pages/reference/providers/gcp/configuration.mdx b/src/pages/reference/providers/gcp/configuration.mdx index a97b86e1c..6449b6f10 100644 --- a/src/pages/reference/providers/gcp/configuration.mdx +++ b/src/pages/reference/providers/gcp/configuration.mdx @@ -58,6 +58,7 @@ config: # set 0 GPUs # See cloudrun configuration docs here: # https://cloud.google.com/run/docs/configuring + # Available since 1.13.0 gpus: 0 # set a timeout of 15 seconds # https://cloud.google.com/run/docs/configuring/request-timeout From f9f186b1f8791c330ab56b8d57ec6ef2ea60e675 Mon Sep 17 00:00:00 2001 From: Tim Holm Date: Fri, 23 Aug 2024 11:00:29 +1000 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Ryan Cartwright <39504851+HomelessDinosaur@users.noreply.github.com> --- src/pages/reference/providers/gcp/configuration.mdx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pages/reference/providers/gcp/configuration.mdx b/src/pages/reference/providers/gcp/configuration.mdx index 6449b6f10..7f4b30016 100644 --- a/src/pages/reference/providers/gcp/configuration.mdx +++ b/src/pages/reference/providers/gcp/configuration.mdx @@ -49,15 +49,15 @@ config: cloudrun: # set 1 CPU # See cloudrun configuration docs here: - # https://cloud.google.com/run/docs/configuring + # https://cloud.google.com/run/docs/configuring/services/cpu cpus: 1 # set 512MB of RAM # See cloudrun configuration docs here: - # https://cloud.google.com/run/docs/configuring/memory-limits + # https://cloud.google.com/run/docs/configuring/services/memory-limits memory: 512 # set 0 GPUs # See cloudrun configuration docs here: - # https://cloud.google.com/run/docs/configuring + # https://cloud.google.com/run/docs/configuring/services/gpu # Available since 1.13.0 gpus: 0 # set a timeout of 15 seconds