Skip to content

Commit 94707b6

Browse files
authored
fix: Ensure at least one permission when calling for on secure resources. (#209)
2 parents 4d87da8 + b68b855 commit 94707b6

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

src/resources/bucket.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ export class BucketResource extends SecureResource<BucketPermission> {
211211
* @param perms the required permission set
212212
* @returns a usable bucket reference
213213
*/
214-
public for(...perms: BucketPermission[]): Bucket {
214+
public for(perm: BucketPermission, ...perms: BucketPermission[]): Bucket {
215215
this.registerPolicy(...perms);
216216

217217
return storage().bucket(this.name);

src/resources/collection.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ export class CollectionResource<
107107
* @param perms the required permission set
108108
* @returns a usable collection reference
109109
*/
110-
public for(...perms: CollectionPermission[]) {
110+
public for(perm: CollectionPermission, ...perms: CollectionPermission[]) {
111111
this.registerPolicy(...perms);
112112

113113
return documents().collection<T>(this.name);

src/resources/queue.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export class QueueResource<
9292
* @param perms the access that the currently scoped function is requesting to this resource.
9393
* @returns a useable queue.
9494
*/
95-
public for(...perms: QueuePermission[]): Queue<T> {
95+
public for(perm: QueuePermission, ...perms: QueuePermission[]): Queue<T> {
9696
this.registerPolicy(...perms);
9797

9898
return queues().queue(this.name);

src/resources/secret.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export class SecretResource extends SecureResource<SecretPermission> {
7979
throw new Error('details unimplemented for secret');
8080
}
8181

82-
public for(...perms: SecretPermission[]): Secret {
82+
public for(perm: SecretPermission, ...perms: SecretPermission[]): Secret {
8383
this.registerPolicy(...perms);
8484

8585
return secrets().secret(this.name);

src/resources/topic.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ export class TopicResource<
136136
* @param perms the required permission set
137137
* @returns a usable topic reference
138138
*/
139-
public for(...perms: TopicPermission[]): Topic<T> {
139+
public for(perm: TopicPermission, ...perms: TopicPermission[]): Topic<T> {
140140
this.registerPolicy(...perms);
141141
return events().topic(this.name);
142142
}

0 commit comments

Comments
 (0)