refactor!: remove shamefullyPatchR2Buckets option (#47)

Author: atinux

README.md

@@ -44,7 +44,6 @@ You can configure additional options using `cloudflareDev: { }` in `nitro.config
 - `persistDir`: Sets the persist dir (default `.wrangler/state/v3`).
 - `configPath`: Sets a custom path for `wrangler.toml` file.
 - `silent`: Hide initial banner.
-- `shamefullyPatchR2Buckets`: Add workaround for https://github.com/cloudflare/workers-sdk/issues/5360
 - `environment`: Sets specific environment (useful for multi-environment configurations)
 
 ## Development

examples/nitro/nitro.config.ts

@@ -2,8 +2,5 @@ import nitroCloudflareBindings from "nitro-cloudflare-dev";
 
 // https://nitro.unjs.io/config
 export default defineNitroConfig({
-  modules: [nitroCloudflareBindings],
-  cloudflareDev: {
-    shamefullyPatchR2Buckets: true,
-  },
+  modules: [nitroCloudflareBindings]
 });

examples/nuxt/nuxt.config.ts

@@ -1,4 +1,5 @@
 // https://nuxt.com/docs/api/configuration/nuxt-config
 export default defineNuxtConfig({
   modules: ["nitro-cloudflare-dev"],
-});
+  compatibilityDate: "2024-10-10",
+});

pnpm-lock.yaml

@@ -16,8 +16,6 @@ declare module "nitropack" {
       environment?: string;
       persistDir?: string;
       silent?: boolean;
-      /** workaround for https://github.com/cloudflare/workers-sdk/issues/5360 */
-      shamefullyPatchR2Buckets?: boolean;
     };
   }
 }
@@ -71,8 +69,6 @@ async function nitroModule(nitro: Nitro) {
   // Share config to the runtime
   nitro.options.runtimeConfig.wrangler = {
     ...nitro.options.runtimeConfig.wrangler,
-    shamefullyPatchR2Buckets:
-      nitro.options.cloudflareDev?.shamefullyPatchR2Buckets,
     configPath,
     persistDir,
     environment: nitro.options.cloudflareDev?.environment,

src/index.ts

@@ -67,7 +67,6 @@ async function _getPlatformProxy() {
     wrangler: {
       configPath: string;
       persistDir: string;
-      shamefullyPatchR2Buckets?: boolean;
       environment?: string;
     };
   } = useRuntimeConfig();
@@ -78,16 +77,6 @@ async function _getPlatformProxy() {
     environment: runtimeConfig.wrangler.environment,
   });
 
-  if (runtimeConfig.wrangler.shamefullyPatchR2Buckets) {
-    const { patchR2Bucket } = await import("./r2-patch");
-    for (const [key, binding] of Object.entries(proxy.env) as [string, any][]) {
-      if (binding.createMultipartUpload) {
-        // console.log("Patching R2Bucket", key);
-        proxy.env[key] = patchR2Bucket(binding);
-      }
-    }
-  }
-
   return proxy;
 }