Skip to content

Commit 592a215

Browse files
authored
Merge pull request #94 from kreuzerk/feature/angular13deps
chore: 🤖 (deps) upgrade deps to v13
2 parents ca2a3e6 + d324fc9 commit 592a215

File tree

5 files changed

+24
-33
lines changed

5 files changed

+24
-33
lines changed

package-lock.json

Lines changed: 16 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,8 @@
3131
"@angular/platform-browser": "~13.2.4",
3232
"@angular/platform-browser-dynamic": "~13.2.4",
3333
"@angular/router": "~13.2.4",
34-
"rxjs": "~6.5.5",
35-
"tsickle": "^0.39.1",
36-
"tslib": "^2.0.0",
34+
"rxjs": "~7.5.0",
35+
"tslib": "^2.3.0",
3736
"zone.js": "~0.11.4"
3837
},
3938
"devDependencies": {

projects/ng-sortgrid/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"version": "0.0.1",
44
"license": "MIT",
55
"peerDependencies": {
6-
"@angular/common": "^12.0.0",
7-
"@angular/core": "^12.0.0"
6+
"@angular/common": "^13.0.0",
7+
"@angular/core": "^13.0.0"
88
},
99
"repository": {
1010
"type": "git",

projects/ng-sortgrid/src/lib/ngsg-item.directive.spec.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@ describe('NgsgItemDirective', () => {
2929
} as any;
3030
const ngsgEventService = new NgsgEventsService();
3131
const scrollHelperService = {
32-
scrollIfNecessary: () => { },
32+
scrollIfNecessary: () => {},
3333
} as any;
3434
const classService = {
35-
addActiveClass: jest.fn()
35+
addActiveClass: jest.fn(),
3636
} as any;
3737

3838
beforeEach(() => {
@@ -48,11 +48,6 @@ describe('NgsgItemDirective', () => {
4848
);
4949
});
5050

51-
it('should not set the draggable attribute on the elment', () => {
52-
sut.ngAfterViewInit();
53-
expect((elementRef.nativeElement as any).draggable).toBeFalsy();
54-
});
55-
5651
it('should not set selectedElements if the event did not occur on the host', () => {
5752
const event = {
5853
target: {

projects/ng-sortgrid/src/lib/ngsg-item.directive.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export class NgsgItemDirective implements OnInit, OnChanges, AfterViewInit, OnDe
9898
}
9999

100100
ngOnDestroy(): void {
101-
this.destroy$.next();
101+
this.destroy$.next(true);
102102
this.destroy$.complete();
103103
}
104104

@@ -146,7 +146,7 @@ export class NgsgItemDirective implements OnInit, OnChanges, AfterViewInit, OnDe
146146
const currentOrder = this.reflectService.reflectChanges(this.ngSortGridGroup, this.el.nativeElement);
147147
this.sorted.next({previousOrder, currentOrder});
148148
this.ngsgStore.resetSelectedItems(this.ngSortGridGroup);
149-
this.ngsgEventService.dropped$.next();
149+
this.ngsgEventService.dropped$.next(true);
150150
}
151151

152152
@HostListener('click')

0 commit comments

Comments
 (0)