feature(upgrade): upgrade ng-sortgrid to Angular 10

nivekcode · nivekcode · commit b7534f151bc2 · 2020-08-26T09:00:56.000+02:00
BREAKING CHANGE: upgrade ng-sortgrid to Angular 10
diff --git a/angular.json b/angular.json
@@ -68,8 +68,7 @@
               "projects/ng-sortgrid/src/lib/ngsg.css",
               "node_modules/@fortawesome/fontawesome-free/css/all.css"
             ],
-            "scripts": [],
-            "es5BrowserSupport": true
+            "scripts": []
           },
           "configurations": {
             "production": {
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -23,50 +23,50 @@
   },
   "private": true,
   "dependencies": {
-    "@angular/animations": "~9.0.2",
-    "@angular/common": "~9.0.2",
-    "@angular/compiler": "~9.0.2",
-    "@angular/core": "~9.0.2",
-    "@angular/forms": "~9.0.2",
-    "@angular/platform-browser": "~9.0.2",
-    "@angular/platform-browser-dynamic": "~9.0.2",
-    "@angular/router": "~9.0.2",
-    "core-js": "^2.5.4",
-    "rxjs": "~6.5.4",
-    "tslib": "^1.10.0",
-    "zone.js": "~0.10.2"
+    "@angular/animations": "~10.0.12",
+    "@angular/common": "~10.0.12",
+    "@angular/compiler": "~10.0.12",
+    "@angular/core": "~10.0.12",
+    "@angular/forms": "~10.0.12",
+    "@angular/platform-browser": "~10.0.12",
+    "@angular/platform-browser-dynamic": "~10.0.12",
+    "@angular/router": "~10.0.12",
+    "core-js": "^3.6.5",
+    "rxjs": "~6.6.2",
+    "tslib": "^2.0.0",
+    "zone.js": "~0.11.1"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "~0.900.3",
-    "@angular-devkit/build-ng-packagr": "~0.900.3",
-    "@angular/cli": "~9.0.3",
-    "@angular/compiler-cli": "~9.0.2",
-    "@angular/language-service": "~9.0.2",
-    "@fortawesome/fontawesome-free": "^5.8.1",
-    "@semantic-release/changelog": "^3.0.1",
-    "@semantic-release/git": "^7.0.6",
-    "@types/jasmine": "~2.8.8",
-    "@types/jasminewd2": "~2.0.3",
-    "@types/node": "^12.11.1",
-    "codecov": "^3.7.1",
-    "codelyzer": "^5.1.2",
-    "copyfiles": "^2.1.0",
-    "husky": "^1.3.1",
-    "jasmine-core": "~2.99.1",
-    "jasmine-spec-reporter": "~4.2.1",
-    "karma": "~4.0.0",
-    "karma-chrome-launcher": "~2.2.0",
-    "karma-coverage-istanbul-reporter": "~2.0.1",
-    "karma-jasmine": "~1.1.2",
-    "karma-jasmine-html-reporter": "^0.2.2",
-    "lint-staged": "^8.1.5",
-    "ng-packagr": "^9.0.0",
-    "prettier": "^1.16.4",
-    "protractor": "~5.4.0",
-    "ts-node": "~7.0.0",
-    "tsickle": "^0.38.0",
-    "tslint": "~5.11.0",
-    "typescript": "^3.7.4"
+    "@angular-devkit/build-angular": "~0.1000.7",
+    "@angular-devkit/build-ng-packagr": "~0.1000.7",
+    "@angular/cli": "~10.0.7",
+    "@angular/compiler-cli": "~10.0.12",
+    "@angular/language-service": "~10.0.12",
+    "@fortawesome/fontawesome-free": "^5.14.0",
+    "@semantic-release/changelog": "^5.0.1",
+    "@semantic-release/git": "^9.0.0",
+    "@types/jasmine": "~3.5.13",
+    "@types/jasminewd2": "~2.0.8",
+    "@types/node": "^14.6.0",
+    "codecov": "^3.7.2",
+    "codelyzer": "^6.0.0",
+    "copyfiles": "^2.3.0",
+    "husky": "^4.2.5",
+    "jasmine-core": "~3.5.0",
+    "jasmine-spec-reporter": "~5.0.0",
+    "karma": "~5.0.0",
+    "karma-chrome-launcher": "~3.1.0",
+    "karma-coverage-istanbul-reporter": "~3.0.2",
+    "karma-jasmine": "~3.3.0",
+    "karma-jasmine-html-reporter": "^1.5.0",
+    "lint-staged": "^10.2.13",
+    "ng-packagr": "^10.0.0",
+    "prettier": "^2.1.1",
+    "protractor": "~7.0.0",
+    "ts-node": "~9.0.0",
+    "tsickle": "^0.39.1",
+    "tslint": "~6.1.0",
+    "typescript": "^3.9.0"
   },
   "husky": {
     "hooks": {
diff --git a/projects/ng-sortgrid-demo/.browserslistrc b/projects/ng-sortgrid-demo/.browserslistrc
diff --git a/projects/ng-sortgrid-demo/tsconfig.app.json b/projects/ng-sortgrid-demo/tsconfig.app.json
@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "../../out-tsc/app",
     "types": []
diff --git a/projects/ng-sortgrid-demo/tsconfig.spec.json b/projects/ng-sortgrid-demo/tsconfig.spec.json
@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "../../out-tsc/spec",
     "types": [
diff --git a/projects/ng-sortgrid/tsconfig.lib.json b/projects/ng-sortgrid/tsconfig.lib.json
@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "../../out-tsc/lib",
     "target": "es2015",
diff --git a/projects/ng-sortgrid/tsconfig.spec.json b/projects/ng-sortgrid/tsconfig.spec.json
@@ -1,5 +1,5 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "../../out-tsc/spec",
     "types": [
diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -0,0 +1,31 @@
+{
+  "compileOnSave": false,
+  "compilerOptions": {
+    "baseUrl": "./",
+    "downlevelIteration": true,
+    "outDir": "./dist/out-tsc",
+    "sourceMap": true,
+    "declaration": false,
+    "module": "es2020",
+    "moduleResolution": "node",
+    "emitDecoratorMetadata": true,
+    "experimentalDecorators": true,
+    "importHelpers": true,
+    "target": "es2015",
+    "typeRoots": [
+      "node_modules/@types"
+    ],
+    "lib": [
+      "es2018",
+      "dom"
+    ],
+    "paths": {
+      "ng-sortgrid": [
+        "dist/ng-sortgrid"
+      ],
+      "ng-sortgrid/*": [
+        "dist/ng-sortgrid/*"
+      ]
+    }
+  }
+}
diff --git a/tsconfig.json b/tsconfig.json
@@ -1,31 +1,23 @@
+/*
+  This is a "Solution Style" tsconfig.json file, and is used by editors and TypeScript’s language server to improve development experience.
+  It is not intended to be used to perform a compilation.
+
+  To learn more about this file see: https://angular.io/config/solution-tsconfig.
+*/
 {
-  "compileOnSave": false,
-  "compilerOptions": {
-    "baseUrl": "./",
-    "downlevelIteration": true,
-    "outDir": "./dist/out-tsc",
-    "sourceMap": true,
-    "declaration": false,
-    "module": "esnext",
-    "moduleResolution": "node",
-    "emitDecoratorMetadata": true,
-    "experimentalDecorators": true,
-    "importHelpers": true,
-    "target": "es2015",
-    "typeRoots": [
-      "node_modules/@types"
-    ],
-    "lib": [
-      "es2018",
-      "dom"
-    ],
-    "paths": {
-      "ng-sortgrid": [
-        "dist/ng-sortgrid"
-      ],
-      "ng-sortgrid/*": [
-        "dist/ng-sortgrid/*"
-      ]
+  "files": [],
+  "references": [
+    {
+      "path": "./projects/ng-sortgrid/tsconfig.lib.json"
+    },
+    {
+      "path": "./projects/ng-sortgrid/tsconfig.spec.json"
+    },
+    {
+      "path": "./projects/ng-sortgrid-demo/tsconfig.app.json"
+    },
+    {
+      "path": "./projects/ng-sortgrid-demo/tsconfig.spec.json"
     }
-  }
+  ]
 }
diff --git a/tslint.json b/tslint.json
@@ -4,15 +4,30 @@
     "codelyzer"
   ],
   "rules": {
+    "align": {
+      "options": [
+        "parameters",
+        "statements"
+      ]
+    },
     "array-type": false,
     "arrow-parens": false,
+    "arrow-return-shorthand": true,
+    "curly": true,
     "deprecation": {
       "severity": "warn"
     },
+    "eofline": true,
     "import-blacklist": [
       true,
       "rxjs/Rx"
     ],
+    "import-spacing": true,
+    "indent": {
+      "options": [
+        "spaces"
+      ]
+    },
     "interface-name": false,
     "max-classes-per-file": false,
     "member-access": false,
@@ -44,7 +59,6 @@
     "no-non-null-assertion": true,
     "no-redundant-jsdoc": true,
     "no-switch-case-fall-through": true,
-    "no-use-before-declare": true,
     "no-var-requires": false,
     "object-literal-key-quotes": [
       true,
@@ -56,16 +70,65 @@
       true,
       "single"
     ],
+    "semicolon": {
+      "options": [
+        "always"
+      ]
+    },
+    "space-before-function-paren": {
+      "options": {
+        "anonymous": "never",
+        "asyncArrow": "always",
+        "constructor": "never",
+        "method": "never",
+        "named": "never"
+      }
+    },
     "trailing-comma": false,
     "no-output-on-prefix": true,
     "no-inputs-metadata-property": true,
     "no-outputs-metadata-property": true,
     "no-host-metadata-property": true,
     "no-input-rename": true,
     "no-output-rename": true,
+    "typedef-whitespace": {
+      "options": [
+        {
+          "call-signature": "nospace",
+          "index-signature": "nospace",
+          "parameter": "nospace",
+          "property-declaration": "nospace",
+          "variable-declaration": "nospace"
+        },
+        {
+          "call-signature": "onespace",
+          "index-signature": "onespace",
+          "parameter": "onespace",
+          "property-declaration": "onespace",
+          "variable-declaration": "onespace"
+        }
+      ]
+    },
     "use-lifecycle-interface": true,
     "use-pipe-transform-interface": true,
     "component-class-suffix": true,
     "directive-class-suffix": true
-  }
+  ,    "variable-name": {
+      "options": [
+        "ban-keywords",
+        "check-format",
+        "allow-pascal-case"
+      ]
+    },
+    "whitespace": {
+      "options": [
+        "check-branch",
+        "check-decl",
+        "check-operator",
+        "check-separator",
+        "check-type",
+        "check-typecast"
+      ]
+    }
+}
 }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "extends": "../../tsconfig.json",`
	`2`	`+ "extends": "../../tsconfig.base.json",`
`3`	`3`	`"compilerOptions": {`
`4`	`4`	`"outDir": "../../out-tsc/app",`
`5`	`5`	`"types": []`