Skip to content

Commit 4e6021e

Browse files
MagicRBMic92
authored andcommitted
Log format improvements
Signed-off-by: magic_rb <[email protected]>
1 parent ec60ec1 commit 4e6021e

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

buildbot_nix/__init__.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -354,8 +354,10 @@ def run(self) -> Generator[Any, Any, None]:
354354

355355
# inject failed buildsteps for any failed eval jobs we got
356356
overall_result = SUCCESS if not self.failed_jobs else util.FAILURE
357+
if self.failed_jobs:
358+
scheduler_log.addStdout(f'The following jobs failed to evaluate:\n');
357359
for failed_job in self.failed_jobs:
358-
scheduler_log.addStdout(f'{failed_job.attr} failed eval');
360+
scheduler_log.addStdout(f'\t- {failed_job.attr} failed eval\n');
359361
yield self.schedule(ss_for_trigger, *self.schedule_eval_failure(build_props, failed_job))
360362

361363
source = f"nix-eval-{self.project.project_id}"
@@ -379,7 +381,7 @@ def run(self) -> Generator[Any, Any, None]:
379381
done: list[BuildTrigger.DoneJob] = []
380382
scheduled: list[BuildTrigger.ScheduledJob] = []
381383
while build_schedule_order or scheduled:
382-
scheduler_log.addStdout('Scheduling..\n')
384+
scheduler_log.addStdout('Scheduling...\n')
383385

384386
# check which jobs should be scheduled now
385387
schedule_now = []
@@ -415,7 +417,7 @@ def run(self) -> Generator[Any, Any, None]:
415417

416418
scheduled.append(BuildTrigger.ScheduledJob(job, brids, resultsDeferred))
417419

418-
scheduler_log.addStdout('Waiting..\n')
420+
scheduler_log.addStdout('Waiting...\n')
419421

420422
# wait for one to complete
421423
self.waitForFinishDeferred = defer.DeferredList(
@@ -432,7 +434,7 @@ def run(self) -> Generator[Any, Any, None]:
432434
done.append(BuildTrigger.DoneJob(job, brids, results))
433435
del scheduled[index]
434436
result = results[0]
435-
scheduler_log.addStdout(f' Found finished build {job.attr}, result {util.Results[result].upper()}\n')
437+
scheduler_log.addStdout(f'Found finished build {job.attr}, result {util.Results[result].upper()}\n')
436438

437439
# if it failed, remove all dependent jobs, schedule placeholders and add them to the list of scheduled jobs
438440
if result != SUCCESS:
@@ -444,10 +446,10 @@ def run(self) -> Generator[Any, Any, None]:
444446
brids, resultsDeferred = yield self.schedule(ss_for_trigger, scheduler, props)
445447
build_schedule_order.remove(removed_job)
446448
scheduled.append(BuildTrigger.ScheduledJob(removed_job, brids, resultsDeferred))
447-
scheduler_log.addStdout(' Removed jobs: ' + ', '.join([ job.drvPath for job in removed ]) + "\n")
449+
scheduler_log.addStdout('\t- removed jobs: ' + ', '.join([ job.drvPath for job in removed ]) + "\n")
448450

449451
overall_result = worst_status(result, overall_result)
450-
scheduler_log.addStdout(f' New result: {util.Results[overall_result].upper()} \n')
452+
scheduler_log.addStdout(f'\t- new result: {util.Results[overall_result].upper()} \n')
451453

452454
for dep in job_closures:
453455
if job.drvPath in job_closures[dep]:

0 commit comments

Comments
 (0)