Skip to content

Commit a3f278e

Browse files
authored
Merge pull request #454 from Erethon/fix-cached-failures-rebuild
Rebuild cached failures on proper workers
2 parents be6b488 + 2b4cd17 commit a3f278e

File tree

1 file changed

+19
-8
lines changed

1 file changed

+19
-8
lines changed

buildbot_nix/buildbot_nix/__init__.py

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -354,14 +354,20 @@ async def run(self) -> int:
354354
error_log.addStderr("\n".join(msg) + "\n")
355355
return util.FAILURE
356356
self.build.addStepsAfterCurrentStep(
357-
nix_build_steps(
358-
self.project,
359-
self.worker_names,
360-
self.post_build_steps,
361-
self.branch_config_dict,
362-
self.outputs_path,
363-
self.show_trace,
364-
)
357+
[
358+
Trigger(
359+
name="Rebuild cached failure",
360+
waitForFinish=True,
361+
schedulerNames=[f"{self.project.project_id}-rebuild"],
362+
haltOnFailure=True,
363+
flunkOnFailure=True,
364+
sourceStamps=[],
365+
alwaysUseLatest=False,
366+
updateSourceStamp=False,
367+
copy_properties=["attr", "system", "branch", "revision"],
368+
set_properties={"reason": "rebuild"},
369+
)
370+
]
365371
)
366372
return util.SUCCESS
367373

@@ -1088,6 +1094,11 @@ def config_for_project(
10881094
name=f"{project.project_id}-nix-register-gcroot",
10891095
builderNames=[f"{project.name}/nix-register-gcroot"],
10901096
),
1097+
# this is triggered from cached failure rebuilds
1098+
schedulers.Triggerable(
1099+
name=f"{project.project_id}-rebuild",
1100+
builderNames=[f"{project.name}/nix-eval"],
1101+
),
10911102
# allow to manually trigger a nix-build
10921103
schedulers.ForceScheduler(
10931104
name=f"{project.project_id}-force",

0 commit comments

Comments
 (0)