Skip to content

Commit bea20e5

Browse files
committed
only show url to users
The time is not very useful in this case. People can just open the link.
1 parent e58a761 commit bea20e5

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

buildbot_nix/__init__.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,7 @@ def schedule_cached_failure(
207207
props = BuildTrigger.set_common_properties(
208208
Properties(), self.project, source, job
209209
)
210-
props.setProperty("first_failure", str(first_failure), source)
211-
props.setProperty("first_failure_url", first_failure_url, source)
210+
props.setProperty("first_failure_url", first_failure.url, source)
212211

213212
return (self.cached_failure_scheduler, props)
214213

@@ -483,7 +482,7 @@ def run(self) -> Generator[Any, Any, None]:
483482
elif failed_build is not None and self.build.reason != "rebuild":
484483
scheduler_log.addStdout(
485484
f"\t- skipping {build.attr} due to cached failure, first failed at {failed_build.time}\n"
486-
+ f"\t see build at {failed_build.url}\n"
485+
f"\t see build at {failed_build.url}\n"
487486
)
488487
build_schedule_order.remove(build)
489488

@@ -747,11 +746,10 @@ def run(self) -> Generator[Any, object, int]:
747746
error_log: StreamLog = yield self.addLog("nix_error")
748747
msg = [
749748
f"{attr} was failed because it has failed previously and its failure has been cached.",
750-
f" first failure time: {self.getProperty('first_failure')}",
751749
]
752750
url = self.getProperty("first_failure_url")
753751
if url:
754-
msg.append(f" first failure url: {url}")
752+
msg.append(f" failed build: {url}")
755753
error_log.addStderr("\n".join(msg) + "\n")
756754
return util.FAILURE
757755

0 commit comments

Comments
 (0)