Skip to content

Commit f067db9

Browse files
committed
only include build error if it's present in the database
1 parent 7037d75 commit f067db9

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

buildbot_nix/__init__.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -730,16 +730,14 @@ def run(self) -> Generator[Any, object, int]:
730730
attr = self.getProperty("attr")
731731
# show eval error
732732
error_log: StreamLog = yield self.addLog("nix_error")
733-
error_log.addStderr(
734-
"\n".join(
735-
[
736-
f"{attr} was failed because it has failed previously and its failure has been cached.",
737-
f" first failure time: {self.getProperty('first_failure')}",
738-
f" first failure url: {self.getProperty('first_failure_url')}",
739-
]
740-
)
741-
+ "\n"
742-
)
733+
msg = [
734+
f"{attr} was failed because it has failed previously and its failure has been cached.",
735+
f" first failure time: {self.getProperty('first_failure')}",
736+
]
737+
url = self.getProperty("first_failure_url")
738+
if url:
739+
msg.append(f" first failure url: {url}")
740+
error_log.addStderr("\n".join(msg) + "\n")
743741
return util.FAILURE
744742

745743

0 commit comments

Comments
 (0)