Devenv setup is broken

[deemp]

There's a report that devenv doesn't work with the latest version of nix-vscode-extensions.

#150 (comment)

For readers: Please explain how to reproduce the problem in your case.

[yurrriq]

I can try to come up with a minimal failing example sometime this week. Meanwhile...

λ git bisect start 585d0a7 4e92639
Bisecting: 12 revisions left to test after this (roughly 4 steps)
[4ec671d536d3b18fdbf4a896d319d180d58ff376] fix(nix): enable vadimcn.vscode-lldb
λ git bisect bad
Bisecting: 5 revisions left to test after this (roughly 3 steps)
[71eec301014562b1ef78abae41e9ded0cc2a704f] fix(nix): don't use a `default.nix` in `nix-dev`
λ git bisect bad
Bisecting: 2 revisions left to test after this (roughly 2 steps)
[695e14d8400bff3ca3100befffb6e241d0575637] refactor(nix): use inputsCombined attrset
λ git bisect good
Bisecting: 0 revisions left to test after this (roughly 1 step)
[800ce13ffe8db0d1923a9cc134da895f69ba321a] fix(nix): test name
λ git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[443c3e3cd4c484683fe9929ba4a454fb2c437a51] fix(nix): modularize - move extensions, tests and helper functions to separate files - make nix-dev
λ git bisect bad
443c3e3cd4c484683fe9929ba4a454fb2c437a51 is the first bad commit

[yurrriq]

I probably can't share too much of my private setup, so I figured I'd try quickly to come up with a minimal failing example... and failed to do so...

The following (with 585d0a7) works, and is not substantially different from my private setup. I'm very confused now.

# devenv.yaml
inputs:
  nix-vscode-extensions:
    url: github:nix-community/nix-vscode-extensions
    inputs:
      nixpkgs:
        follows: nixpkgs
  nixpkgs:
    url: github:cachix/devenv-nixpkgs/rolling

# devenv.nix
{ inputs, lib, pkgs, ... }:

{
  overlays = [
    inputs.nix-vscode-extensions.overlays.default
  ];
  packages = with pkgs; [
    nixd
    (
      let
        extensions = (forVSCodeVersion (lib.getVersion vscodium)).vscode-marketplace;
      in
        vscode-with-extensions.override {
          vscode = vscodium;
          vscodeExtensions = with extensions; [
            bbenoist.nix
            jnoortheen.nix-ide
            mkhl.direnv
          ];
        }
    )
  ];
}

The following is more similar to my failing case, but it also works in isolation, so now I'm even more confused.

# devenv.nix
{ config, inputs, lib, pkgs, ... }:

let
  cfg = config.mfe;

  nix-vscode-extensions = config.lib.getInput {
    name = "nix-vscode-extensions";
    url = "github:nix-community/nix-vscode-extensions";
    attribute = "mfe.enable";
    follows = [ "nixpkgs" ];
  };
in
{
  options.mfe = {
    enable = lib.mkEnableOption "nix-community/nix-vscode-extensions#176";
    package = lib.mkOption {
      type = lib.types.package;
      default = pkgs.vscodium;
      defaultText = lib.literalExpression "pkgs.vscodium";
      description = ''
        The VS Code package to use.
      '';
      example = lib.literalExpression "pkgs.vscode";
    };
  };

  config = lib.mkIf cfg.enable {
    overlays = [
      nix-vscode-extensions.overlays.default
    ];
    packages = with pkgs; [
      nixd
      (
        let
          extensions = (forVSCodeVersion (lib.getVersion cfg.package)).vscode-marketplace;
        in
        vscode-with-extensions.override {
          vscode = cfg.package;
          vscodeExtensions = with extensions; [
            bbenoist.nix
            jnoortheen.nix-ide
            mkhl.direnv
          ];
        }
    )
    ];
  };
}

# devenv.local.nix
{
  mfe.enable = true;
}

[yurrriq]

Another wrinkle... with cachix/devenv@a444c2e (as opposed to v1.11.2) it works again. Seems perhaps to be a problem with devenv 1.11.2 rather than this repo. Thanks for your prompt attention, anyway.

[yurrriq]

Okay, wait. I think I maybe found the issue after all? Perhaps it has to do with another devenv module also defining overlays. I'll try to get this sorted with Domen.

[yurrriq]

Or not. I have no idea anymore... If I pin this repo to 4e92639 then everything works, so that's what I'll do for now.

[deemp]

@yurrriq thank you for attempts to provide a minimal falling example.

I think you can avoid the interference with devenv and whatever else if you produce the extensions attrset using just nixpkgs.

https://github.com/nix-community/nix-vscode-extensions#get-extensions-via-the-overlay

[yurrriq]

Could you please explain how that's substantially different from what I'm doing? It's also curious that this worked until to the bad commit mentioned above.

[deemp]

@yurrriq you added an overlay from nix-vscode-extensions to overlays. I assume there are other overlays in your setup. I assume each overlay modifies nixpkgs in some way. I assume there may be conflicting modifications which lead to the error.

On the other hand, if you construct extensions by using a single overlay with plain nixpkgs, there is no chance of conflicting modifications.

[deemp]

@yurrriq what do you mean? Does the suggested approach not work with the latest commits?

It's also curious that this worked until to the bad commit mentioned above.

[yurrriq]

Thanks, will try your suggestion. I meant that as above (including this overlay in overlays, among others elsewhere) worked with old commits.

[yurrriq]

That doesn't seem to fix it, so I'll keep pinning 4e92639 for now, I guess.

[deemp]

@yurrriq that's unfortunate that the problem persists 😕.

Can you send the error log? You can remove the sensitive information if necessary.

Additionally, if you have time I suggest that you try to again use the nix-vscode-extensions overlay and remove other overlays one by one until the problem is gone. Then, you'll either identify which overlay causes the problem or see that this problem has nothing to do with other overlays.

Perhaps you'll be able to minimize the example further by removing most of the other code except overlays.

[yurrriq]

The error log is massive and complains about cachix.package something something. I'll see if I can find some time tomorrow.

[deemp]

@yurrriq I got rid of flake-parts in flake.nix in c528f11. So, there's no processing of overlays. The overlay comes directly from ./nix/overlay.nix.

Please try using one of the latest commits. Use at least e58a435 because before that commit, a fix was merged for a probably related problem #177.