Skip to content

Commit faa31d9

Browse files
committed
Revert "tests/modules-performance: add nvim-cmp to extraPlugins when necessary"
This reverts commit bb5b0a2. This change defeats the purpose of the dependency test. Revert it. The test should verify that dependencies are correctly pulled. If upstream plugin doesn't have dependency anymore, then a suitable alternative should be used, not dependencies added manually.
1 parent 7bb135b commit faa31d9

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

tests/test-sources/modules/performance/combine-plugins.nix

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,6 @@ in
6464
extraPlugins = with pkgs.vimPlugins; [
6565
# Depends on nvim-cmp
6666
cmp-dictionary
67-
# We have to manually add cmp-dictionary's dependence: nvim-cmp
68-
nvim-cmp
6967
# Depends on telescope-nvim which itself depends on plenary-nvim
7068
telescope-undo-nvim
7169
];
@@ -334,8 +332,6 @@ in
334332
telescope-nvim
335333
# Only its dependency (nvim-cmp) won't be combined, but not the plugin itself
336334
cmp-dictionary
337-
# We have to manually add cmp-dictionary's dependence: nvim-cmp
338-
nvim-cmp
339335
# More plugins
340336
gitsigns-nvim
341337
luasnip

0 commit comments

Comments
 (0)