Skip to content

plugins/lsp: fix volar tsls integration location #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2025
Merged

plugins/lsp: fix volar tsls integration location #3618

merged 1 commit into from
Aug 23, 2025

Conversation

yzx9
Copy link
Contributor

@yzx9 yzx9 commented Aug 12, 2025 •
edited
Loading

This PR fixes the incorrect location in Volar LSP by updating it. The old location no longer exists.

  • old: ${lib.getBin cfg.package}/lib/node_modules/@vue/language-server
  • new: ${lib.getBin cfg.package}/lib/language-tools/packages/language-server
> tree /nix/store/3h6sfwmwxl3x8vfasw5iaplzd6xjiip4-vue-language-server-3.0.4 -L 4
/nix/store/3h6sfwmwxl3x8vfasw5iaplzd6xjiip4-vue-language-server-3.0.4
├── bin
│   └── vue-language-server
└── lib
    └── language-tools
        ├── extensions
        │   └── vscode
        ├── node_modules
        │   ├── @lerna-lite
        │   ├── @tsslint
        │   ├── @typescript-eslint
        │   ├── dprint -> .pnpm/[email protected]/node_modules/dprint
        │   ├── oxlint -> .pnpm/[email protected]/node_modules/oxlint
        │   ├── typescript -> .pnpm/[email protected]/node_modules/typescript
        │   └── vitest -> .pnpm/[email protected]_@[email protected]/node_modules/vitest
        └── packages
            ├── component-meta
            ├── component-type-helpers
            ├── language-core
            ├── language-plugin-pug
            ├── language-server
            ├── language-service
            ├── tsc
            └── typescript-plugin

23 directories, 1 file

To quick test in your own configuration, please set:

plugins.lsp.servers = {
  ts_ls = {
    enable = true;
    filetypes = [ "vue" ];
    extraOptions = {
      init_options = {
        plugins = [
          {
            name = "@vue/typescript-plugin";
            location = "${lib.getBin pkgs.vue-language-server}/lib/language-tools/packages/language-server";
            languages = [ "vue" ];
          }
        ];
      };
    };
  };
  volar = {
    enable = true;
    tslsIntegration = false;
  };
};

MattSturgeon
MattSturgeon approved these changes Aug 15, 2025
View reviewed changes
Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@khaneliman khaneliman added this pull request to the merge queue Aug 23, 2025
Merged via the queue into nix-community:main with commit e03ede7 Aug 23, 2025
3 checks passed
@yzx9 yzx9 deleted the volar-tsls-integration branch August 23, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattSturgeon MattSturgeon MattSturgeon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yzx9 @MattSturgeon @khaneliman