Skip to content

Commit 2086102

Browse files
committed
Respond to @SteveLauC's comments
1 parent 181a600 commit 2086102

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

src/sys/socket/sockopt.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ use std::ffi::{OsStr, OsString};
1111
use std::mem::{self, MaybeUninit};
1212
use std::os::unix::ffi::OsStrExt;
1313
#[cfg(linux_android)]
14-
use std::os::unix::io::AsFd;
15-
use std::os::unix::io::AsRawFd;
14+
use std::os::unix::io::{AsFd, AsRawFd};
1615

1716
// Constants
1817
// TCP_CA_NAME_MAX isn't defined in user space include files
@@ -54,9 +53,9 @@ macro_rules! setsockopt_impl {
5453
fd: &F,
5554
val: &$ty,
5655
) -> $crate::Result<()> {
56+
use std::os::fd::AsRawFd;
5757
use $crate::sys::socket::sockopt::Set;
58-
let setter: $setter =
59-
$crate::sys::socket::sockopt::Set::new(val);
58+
let setter: $setter = Set::new(val);
6059
let level = $level;
6160
let flag = $flag;
6261
let res = unsafe {
@@ -107,9 +106,9 @@ macro_rules! getsockopt_impl {
107106
&self,
108107
fd: &F,
109108
) -> $crate::Result<$ty> {
109+
use std::os::fd::AsRawFd;
110110
use $crate::sys::socket::sockopt::Get;
111-
let mut getter: $getter =
112-
$crate::sys::socket::sockopt::Get::uninit();
111+
let mut getter: $getter = Get::uninit();
113112
let level = $level;
114113
let flag = $flag;
115114
let res = unsafe {

test/sys/test_sockopt.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1054,7 +1054,6 @@ mod sockopt_impl {
10541054
getsockopt, setsockopt, socket, AddressFamily, SockFlag, SockProtocol,
10551055
SockType,
10561056
};
1057-
use std::os::unix::io::AsRawFd;
10581057

10591058
sockopt_impl!(
10601059
Linger,

0 commit comments

Comments
 (0)