Improvements to groupFlank and groupSuppress performance (#463)

* Improvements to groupFlank and groupSuppress performance

Adds a check count to further limit terrainIntersect checks being run.

* Update fnc_doGroupFlank.sqf

Fixed unit stance was reversed! Suppressing units should crouch-- moving units should be standing!

Author: nk3nny

addons/main/functions/GroupAction/fnc_doGroupFlank.sqf

@@ -40,17 +40,19 @@ private _leaderAlone = ( ( _units - crew _leader) findIf { _x distanceSqr _leade
 
 [_posList, true] call CBA_fnc_shuffle;
 private _index = -1;
+private _checkCount = 3;
+
 {
     private _unit = _x;
     private _suppressed = (getSuppression _unit) > 0.5;
     private _activeTeam = (_forEachIndex % 2) isEqualTo _teamAlpha;
 
     // stance
     private _unitPos = call {
-        if (_leaderAlone && {_unit isEqualTo _leader}) exitWith {"DOWN"};
+        if (_suppressed) exitWith {"DOWN"};
+        if (_unit isEqualTo _leader) exitWith {["MIDDLE", "DOWN"] select _leaderAlone};
         private _crouched = (stance _unit) isEqualTo "CROUCH";
-        if (_suppressed) exitWith {["UP", "DOWN"] select _crouched};
-        if (_crouched && _activeTeam) exitWith {"UP"};
+        if (_crouched && !_activeTeam) exitWith {"UP"};
         "MIDDLE"
     };
     _unit setUnitPos _unitPos;
@@ -61,8 +63,9 @@ private _index = -1;
     _unit setVariable [QGVAR(currentTask), "Group Flank", GVAR(debug_functions)];
 
     // check suppress position
-    if (_activeTeam && _index isEqualTo -1) then {
+    if (_activeTeam && _checkCount > 0 && _index isEqualTo -1) then {
         _index = [_x, _posList] call FUNC(checkVisibilityList);
+        _checkCount = _checkCount - 1;
     };
 
     // suppress

addons/main/functions/GroupAction/fnc_doGroupSuppress.sqf

@@ -29,10 +29,14 @@ _vehicles = _vehicles select { canFire _x };
 // infantry
 [_posList, true] call CBA_fnc_shuffle;
 private _index = -1;
+private _checkCount = 3;
 
 {
     // find target
-    if (_index isEqualTo -1)then {_index = [_x, _posList] call FUNC(checkVisibilityList);};
+    if (_index isEqualTo -1 && _checkCount > 0) then {
+        _index = [_x, _posList] call FUNC(checkVisibilityList);
+        _checkCount = _checkCount - 1;
+    };
 
     // found good target
     if (_index isNotEqualTo -1) then {
@@ -65,7 +69,7 @@ private _index = -1;
     private _vehicle = _x;
 
     // find target
-    if (_index isEqualTo -1)then {_index = [_vehicle, _posList] call FUNC(checkVisibilityList);};
+    if (_index isEqualTo -1) then {_index = [_vehicle, _posList] call FUNC(checkVisibilityList);};
 
     // execute suppression
     if (_index isNotEqualTo -1) then {