Update TfsWorkItemMigrationProcessor.cs

kaflake · web-flow · commit 00a2e81eb9ab · 2025-04-02T08:44:58.000+02:00
ClosedDate population called two times. One time without exception handling. If there is no "Microsoft.VSTS.Common.ClosedDate" in the oldWorkItem it will crash.
diff --git a/src/MigrationTools.Clients.TfsObjectModel/Processors/TfsWorkItemMigrationProcessor.cs b/src/MigrationTools.Clients.TfsObjectModel/Processors/TfsWorkItemMigrationProcessor.cs
@@ -417,10 +417,6 @@ private void PopulateWorkItem(WorkItemData oldWorkItemData, WorkItemData newWork
             }
 
             newWorkItem.Title = oldWorkItem.Title;
-            if (newWorkItem.Fields.Contains("Microsoft.VSTS.Common.ClosedDate") && newWorkItem.Fields["Microsoft.VSTS.Common.ClosedDate"].IsEditable)
-            {
-                newWorkItem.Fields["Microsoft.VSTS.Common.ClosedDate"].Value = oldWorkItem.Fields["Microsoft.VSTS.Common.ClosedDate"].Value;
-            }
             newWorkItem.State = oldWorkItem.State;
             try
             {

Original file line number	Diff line number	Diff line change
`@@ -417,10 +417,6 @@ private void PopulateWorkItem(WorkItemData oldWorkItemData, WorkItemData newWork`
`417`	`417`	`}`
`418`	`418`
`419`	`419`	`newWorkItem.Title = oldWorkItem.Title;`
`420`		`- if (newWorkItem.Fields.Contains("Microsoft.VSTS.Common.ClosedDate") && newWorkItem.Fields["Microsoft.VSTS.Common.ClosedDate"].IsEditable)`
`421`		`- {`
`422`		`- newWorkItem.Fields["Microsoft.VSTS.Common.ClosedDate"].Value = oldWorkItem.Fields["Microsoft.VSTS.Common.ClosedDate"].Value;`
`423`		`- }`
`424`	`420`	`newWorkItem.State = oldWorkItem.State;`
`425`	`421`	`try`
`426`	`422`	`{`