PR 33: Merge AddConfigurationJson to master +semver:patch

 - Started adding configration to create fully configurable with no compile..
 - Added all Field mapps to configuration +semver: major
 - Added all work item type mappings... only processors left!
 - And processors
 - i hate serilisation
 - Fixed json hadling of custom objects
 - Processor done too... now to add other processors...
 - Moved config bits into engine...
 - Refactor to bring Config and Execution to the same format
 - Added version to AI +semver:patch
...

Author: MrHinsh

TfsWitMigrator.Core/Configuration/EngineConfiguration.cs

@@ -12,8 +12,8 @@ namespace VSTS.DataBulkEditor.Engine.Configuration
     public class EngineConfiguration
     {
         public bool TelemetryEnableTrace { get; set; }
-        public TeamProjectConfig Target { get; set; }
         public TeamProjectConfig Source { get; set; }
+        public TeamProjectConfig Target { get; set; }
         public string ReflectedWorkItemIDFieldName { get; set; }
         public List<IFieldMapConfig> FieldMaps { get; set; }
         public Dictionary<string, string> WorkItemTypeDefinition { get; set; }
@@ -23,8 +23,8 @@ public static EngineConfiguration GetDefault()
         {
             EngineConfiguration ec = new EngineConfiguration();
             ec.TelemetryEnableTrace = true;
-            ec.Target = new TeamProjectConfig() { Name = "DemoProjt", Collection = new Uri("https://sdd2016.visualstudio.com/") };
             ec.Source = new TeamProjectConfig() { Name = "DemoProjs", Collection = new Uri("https://sdd2016.visualstudio.com/") };
+            ec.Target = new TeamProjectConfig() { Name = "DemoProjt", Collection = new Uri("https://sdd2016.visualstudio.com/") };
             ec.ReflectedWorkItemIDFieldName = "TfsMigrationTool.ReflectedWorkItemId";
             ec.FieldMaps = new List<IFieldMapConfig>();
             ec.FieldMaps.Add(new FieldValueMapConfig()

TfsWitMigrator.Core/Execution/MigrationContext/WorkItemMigrationContext.cs

@@ -88,13 +88,12 @@ internal override void InternalExecute()
                             newwit.Save();
                             Trace.WriteLine(string.Format("...Saved as {0}", newwit.Id));
                             newwit.Fields["System.CreatedDate"].Value = sourceWI.Fields["System.CreatedDate"].Value;
-                            newwit.Save();
                             Trace.WriteLine(string.Format("...And Date Created Updated"));
                             if (sourceWI.Fields.Contains(me.ReflectedWorkItemIdFieldName))
                             {
                                 sourceWI.Fields[me.ReflectedWorkItemIdFieldName].Value = targetStore.CreateReflectedWorkItemId(newwit);
-                                sourceWI.Save();
                             }
+                            newwit.Save();
 
                         }
                         catch (Exception ex)
@@ -115,8 +114,7 @@ internal override void InternalExecute()
                     //  sourceWI.Open();
                     //  sourceWI.SyncToLatest();
                     //  sourceWI.Fields["TfsMigrationTool.ReflectedWorkItemId"].Value = destWIFound[0].Id;
-
-                    sourceWI.Save();
+                    //sourceWI.Save();
                 }
                 witstopwatch.Stop();
                 elapsedms = elapsedms + witstopwatch.ElapsedMilliseconds;
@@ -261,8 +259,8 @@ private static string ReplaceFirstOccurence(string wordToReplace, string replace
 
         private static void BuildFieldTable(WorkItem oldWi, StringBuilder history, bool useHTML = false)
         {
+            history.Append("<p>&nbsp;</p>");
             if (useHTML) {
-                history.Append("<p>&nbsp;</p>");
                 history.Append("<table border='1' cellpadding='2' style='width:100%;border-color:#C0C0C0;'><tr><td><b>Field</b></td><td><b>Value</b></td></tr>");
             }
             foreach (Field f in oldWi.Fields)
@@ -274,7 +272,7 @@ private static void BuildFieldTable(WorkItem oldWi, StringBuilder history, bool
                         history.AppendFormat("<tr><td style='text-align:right;white-space:nowrap;'><b>{0}</b></td><td>n/a</td></tr>", f.Name);
                     } else
                     {
-                        history.AppendLine(string.Format("{0}: null", f.Name));
+                        history.AppendLine(string.Format("{0}: null<br />", f.Name));
                     }
                 }
                 else
@@ -285,16 +283,16 @@ private static void BuildFieldTable(WorkItem oldWi, StringBuilder history, bool
 
                     }else
                     {
-                        history.AppendLine(string.Format("{0}: {1}", f.Name, f.Value.ToString()));
+                        history.AppendLine(string.Format("{0}: {1}<br />", f.Name, f.Value.ToString()));
                     }
                 }
 
             }
             if (useHTML)
             {
                 history.Append("</table>");
-                history.Append("<p>&nbsp;</p>");
             }
+            history.Append("<p>&nbsp;</p>");
         }
 
         private static void BuildCommentTable(WorkItem oldWi, StringBuilder history)

TfsWitMigrator.Core/MigrationEngine.cs

@@ -38,10 +38,13 @@ private void ProcessConfiguration(EngineConfiguration config)
             this.SetSource(new TeamProjectContext(config.Source.Collection, config.Source.Name));
             this.SetTarget(new TeamProjectContext(config.Target.Collection, config.Target.Name));
             this.SetReflectedWorkItemIdFieldName(config.ReflectedWorkItemIDFieldName);
-            foreach (IFieldMapConfig fieldmapConfig in config.FieldMaps)
+            if (config.FieldMaps != null)
             {
-                this.AddFieldMap(fieldmapConfig.WorkItemTypeName, (IFieldMap)Activator.CreateInstance(fieldmapConfig.FieldMap, fieldmapConfig));
-            }
+                foreach (IFieldMapConfig fieldmapConfig in config.FieldMaps)
+                {
+                    this.AddFieldMap(fieldmapConfig.WorkItemTypeName, (IFieldMap)Activator.CreateInstance(fieldmapConfig.FieldMap, fieldmapConfig));
+                }
+            }            
             foreach (string key in config.WorkItemTypeDefinition.Keys)
             {
                 this.AddWorkItemTypeDefinition(key, new DescreteWitdMapper(config.WorkItemTypeDefinition[key]));