CS1998 This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Author: satano

src/MigrationTools.Host/Commands/CommandBase.cs

@@ -111,10 +111,9 @@ public sealed override async Task<int> ExecuteAsync(CommandContext context, TSet
             }
         }
 
-        internal virtual async Task<int> ExecuteInternalAsync(CommandContext context, TSettings settings)
+        internal virtual Task<int> ExecuteInternalAsync(CommandContext context, TSettings settings)
         {
-            // no-op
-            return 0;
+            return Task.FromResult( 0);
         }
 
         public void RunStartupLogic(TSettings settings)

src/MigrationTools.Host/Commands/ConfigurationBuilderCommand.cs

@@ -39,7 +39,7 @@ public ConfigurationBuilderCommand(
         Layout layout = new Layout("Root");
 
 
-        public override async Task<int> ExecuteAsync(CommandContext context, ConfigurationBuilderCommandSettings settings)
+        public override Task<int> ExecuteAsync(CommandContext context, ConfigurationBuilderCommandSettings settings)
         {
             int _exitCode;
 
@@ -58,10 +58,6 @@ public override async Task<int> ExecuteAsync(CommandContext context, Configurati
                 optionsUpgrader.UpgradeConfiguration(optionsBuilder, configFile);
                 _logger.LogInformation("Configuration loaded & Upgraded to latest...");
 
-
-          
-
-
                 var configurationEditorOptions = new[]
                 {
                     "Apply Templates",
@@ -116,7 +112,7 @@ public override async Task<int> ExecuteAsync(CommandContext context, Configurati
                 // Stop the application once the work is done
                 _appLifetime.StopApplication();
             }
-            return _exitCode;
+            return Task.FromResult(_exitCode);
         }
 
         private void DisplayCurrentOptions(OptionsConfigurationBuilder optionsBuilder)
@@ -171,7 +167,7 @@ private void SaveOptions(OptionsConfigurationBuilder optionsBuilder, string conf
 
         private void SelectTemplateToApply(OptionsConfigurationBuilder optionsBuilder, string configFile)
         {
-            
+
             bool shouldExit = false;
             while (!shouldExit)
             {

src/MigrationTools.Host/Commands/ExecuteMigrationCommand.cs

@@ -45,18 +45,18 @@ public ExecuteMigrationCommand(
             _appLifetime = appLifetime;
         }
 
-        internal override async Task<int> ExecuteInternalAsync(CommandContext context, ExecuteMigrationCommandSettings settings)
+        internal override Task<int> ExecuteInternalAsync(CommandContext context, ExecuteMigrationCommandSettings settings)
         {
             int _exitCode;
             try
             {
-                    // KILL if the config is not valid
-                    if (!VersionOptions.ConfigureOptions.IsConfigValid(Configuration))
-                    {
-                        CommandActivity.AddEvent(new ActivityEvent("ConfigIsNotValid"));
-                        BoilerplateCli.ConfigIsNotValidMessage(Configuration, Log.Logger);
-                        return -1;
-                    }
+                // KILL if the config is not valid
+                if (!VersionOptions.ConfigureOptions.IsConfigValid(Configuration))
+                {
+                    CommandActivity.AddEvent(new ActivityEvent("ConfigIsNotValid"));
+                    BoilerplateCli.ConfigIsNotValidMessage(Configuration, Log.Logger);
+                    return Task.FromResult(-1);
+                }
                 var migrationEngine = _services.GetRequiredService<IMigrationEngine>();
                 migrationEngine.Run();
                 _exitCode = 0;
@@ -71,7 +71,7 @@ internal override async Task<int> ExecuteInternalAsync(CommandContext context, E
                 foreach (var failure in ex.Failures)
                 {
                     _logger.LogCritical(failure);
-                }                
+                }
                 _logger.LogCritical("------------");
                 _exitCode = 1;
             }
@@ -88,7 +88,7 @@ internal override async Task<int> ExecuteInternalAsync(CommandContext context, E
                 // Stop the application once the work is done
                 _appLifetime.StopApplication();
             }
-            return _exitCode;
+            return Task.FromResult(_exitCode);
         }
     }
 }

src/MigrationTools.Host/Commands/InitMigrationCommand.cs

@@ -32,7 +32,7 @@ public InitMigrationCommand(IHostApplicationLifetime appLifetime, IServiceProvid
             _logger = logger;
         }
 
-        internal override async Task<int> ExecuteInternalAsync(CommandContext context, InitMigrationCommandSettings settings)
+        internal override Task<int> ExecuteInternalAsync(CommandContext context, InitMigrationCommandSettings settings)
         {
             int _exitCode;
             try
@@ -81,7 +81,7 @@ internal override async Task<int> ExecuteInternalAsync(CommandContext context, I
                 // Stop the application once the work is done
                 Lifetime.StopApplication();
             }
-            return _exitCode;
+            return Task.FromResult(_exitCode);
         }
     }
 }

src/MigrationTools.Host/Commands/UpgradeConfigCommand.cs

@@ -37,14 +37,12 @@ internal class UpgradeConfigCommand : CommandBase<UpgradeConfigCommandSettings>
 
         private readonly ILogger _logger;
 
-       
-
         public UpgradeConfigCommand(IHostApplicationLifetime appLifetime, IServiceProvider services, IDetectOnlineService detectOnlineService, IDetectVersionService2 detectVersionService, ILogger<CommandBase<UpgradeConfigCommandSettings>> logger, ITelemetryLogger telemetryLogger, IMigrationToolVersion migrationToolVersion, IConfiguration configuration, ActivitySource activitySource) : base(appLifetime, services, detectOnlineService, detectVersionService, logger, telemetryLogger, migrationToolVersion, configuration, activitySource)
         {
             _logger = logger;
         }
 
-        internal override async Task<int> ExecuteInternalAsync(CommandContext context, UpgradeConfigCommandSettings settings)
+        internal override Task<int> ExecuteInternalAsync(CommandContext context, UpgradeConfigCommandSettings settings)
         {
             CommandActivity.SetTagsFromObject(settings);
             int _exitCode = 0;
@@ -63,7 +61,7 @@ internal override async Task<int> ExecuteInternalAsync(CommandContext context, U
             File.WriteAllText(configFile, json);
             _logger.LogInformation("New {configFile} file has been created", configFile);
             Console.WriteLine(json);
-            return _exitCode;
+            return Task.FromResult(_exitCode);
         }