MSTEST0037 Use 'Assert.HasCount' instead of 'Assert.AreEqual'

Author: satano

src/MigrationTools.Clients.TfsObjectModel.Tests/Tools/TfsRevisionManagerTests.cs

@@ -65,7 +65,7 @@ public void TfsRevisionManagerToolSync1()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, target);
 
-            Assert.AreEqual(1, revs.Count);
+            Assert.HasCount(1, revs);
         }
 
         [TestMethod(), TestCategory("L0")]
@@ -79,7 +79,7 @@ public void TfsRevisionManagerToolSync10()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, target);
 
-            Assert.AreEqual(10, revs.Count);
+            Assert.HasCount(10, revs);
         }
 
         [TestMethod(), TestCategory("L0")]
@@ -98,7 +98,7 @@ public void TfsRevisionManagerToolReplayRevisionsOff()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, target);
 
-            Assert.AreEqual(1, revs.Count);
+            Assert.HasCount(1, revs);
         }
 
 
@@ -137,7 +137,7 @@ public void TfsRevisionManagerToolMaxRevision56()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, target);
 
-            Assert.AreEqual(5, revs.Count);
+            Assert.HasCount(5, revs);
         }
 
         [TestMethod(), TestCategory("L0")]
@@ -155,7 +155,7 @@ public void TfsRevisionManagerToolMaxRevision59()
 
             var revs = processorEnricher.GetRevisionsToMigrate(source, null);
 
-            Assert.AreEqual(5, revs.Count);
+            Assert.HasCount(5, revs);
         }
 
         [TestMethod(), TestCategory("L0")]

src/MigrationTools.Tests/Core/Clients/WorkItemMigrationClientTests.cs

@@ -1,6 +1,5 @@
 using System.Linq;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
-using MigrationTools.Clients;
 using MigrationTools.DataContracts;
 
 namespace MigrationTools.Clients.Tests
@@ -14,7 +13,7 @@ public void WorkItemMigrationClientGetWorkItemsTest()
             IWorkItemMigrationClient sink = new WorkItemMigrationClientMock();
             var list = sink.GetWorkItems();
             //
-            Assert.IsTrue(list.Count() == 5);
+            Assert.HasCount(5, list);
         }
 
         [TestMethod(), TestCategory("L0")]
@@ -24,7 +23,7 @@ public void WorkItemMigrationClientPersistNewWorkItemTest()
             sink.PersistWorkItem(new WorkItemData { Title = "Item 6" });
             //
             var list = sink.GetWorkItems();
-            Assert.IsTrue(list.Count() == 6);
+            Assert.HasCount(6, list);
         }
 
         [TestMethod(), TestCategory("L0")]
@@ -36,9 +35,9 @@ public void WorkItemMigrationClientPersistExistingItemTest()
             sink.PersistWorkItem(workItem);
             //
             var list = sink.GetWorkItems();
-            Assert.IsTrue(list.Count() == 5);
+            Assert.HasCount(5, list);
             var updatedworkItem = sink.GetWorkItems().First();
-            Assert.IsTrue(updatedworkItem.Title == workItem.Title);
+            Assert.AreEqual(workItem.Title, updatedworkItem.Title);
         }
     }
-}
+}

src/MigrationTools.Tests/Options/OptionsConfigurationUpgraderTfsNodeStructureTests.cs

@@ -1,5 +1,4 @@
-using System.Collections.Generic;
-using System.Linq;
+using System.Linq;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
@@ -66,8 +65,8 @@ public void TfsNodeStructureOptions_DictionaryMappingsFormat_ShouldConvertToArra
                 var areasChildren = areasMappingsSection.GetChildren().ToList();
                 var iterationsChildren = iterationsMappingsSection.GetChildren().ToList();
 
-                Assert.AreEqual(2, areasChildren.Count, "Should have 2 areas mappings");
-                Assert.AreEqual(1, iterationsChildren.Count, "Should have 1 iterations mapping");
+                Assert.HasCount(2, areasChildren, "Should have 2 areas mappings");
+                Assert.HasCount(1, iterationsChildren, "Should have 1 iterations mapping");
 
                 // Verify the dictionary format detection logic
                 var firstAreaChild = areasChildren.FirstOrDefault();
@@ -131,11 +130,11 @@ public void TfsNodeStructureOptions_ArrayMappingsFormat_ShouldNotBeModified()
                 Assert.IsTrue(areasMappingsSection.Exists(), "Areas.Mappings section should exist");
 
                 var areasChildren = areasMappingsSection.GetChildren().ToList();
-                Assert.AreEqual(1, areasChildren.Count, "Should have 1 areas mapping");
+                Assert.HasCount(1, areasChildren, "Should have 1 areas mapping");
 
                 var firstChild = areasChildren.FirstOrDefault();
                 Assert.IsNotNull(firstChild, "Should have first mapping");
-                
+
                 // In array format, keys should be numeric indices
                 Assert.IsTrue(int.TryParse(firstChild.Key, out _), "Key should be numeric (array format)");
             }
@@ -148,4 +147,4 @@ public void TfsNodeStructureOptions_ArrayMappingsFormat_ShouldNotBeModified()
             }
         }
     }
-}
+}

src/MigrationTools.Tests/Tools/FieldMaps/FieldCalculationMapTests.cs

@@ -31,7 +31,7 @@ public void FieldCalculationMapOptions_SetExampleConfigDefaults_ShouldSetCorrect
             // Assert
             Assert.AreEqual("[x]*2", options.expression);
             Assert.AreEqual("Custom.FieldC", options.targetField);
-            Assert.AreEqual(1, options.parameters.Count);
+            Assert.HasCount(1, options.parameters);
             Assert.AreEqual("Custom.FieldB", options.parameters["x"]);
             CollectionAssert.Contains(options.ApplyTo, "SomeWorkItemType");
         }