PR 30: Updated code to try and improve performance. +semver: minor

 - Updated code to try and improve performance. +semver: minor

Author: MrHinsh

TfsWitMigrator.Core/ComponentContext/TfsQueryContext.cs

@@ -45,7 +45,7 @@ public WorkItemCollection Execute()
                             { "QueryTime", queryTimer.ElapsedMilliseconds },
                           { "QueryCount", wc.Count }
                       });
-                Trace.TraceInformation(string.Format(" Query Complete: found {0} work items ", wc.Count));
+                Trace.TraceInformation(string.Format(" Query Complete: found {0} work items in {1}ms ", wc.Count, queryTimer.ElapsedMilliseconds));
 
         }
             catch (Exception ex)

TfsWitMigrator.Core/ComponentContext/WorkItemStoreContext.cs

@@ -93,11 +93,14 @@ public WorkItem FindReflectedWorkItem(WorkItem workItemToFind, string reflectedW
                 }                
             }
             if (found == null) { found = FindReflectedWorkItemByReflectedWorkItemId(ReflectedWorkItemId, reflectedWotkItemIdField); }
-            if (found == null) { found = FindReflectedWorkItemByMigrationRef(ReflectedWorkItemId); }
-            //if (found == null) { found = FindReflectedWorkItemByTitle(workItemToFind.Title); }
+            if (!workItemToFind.Fields.Contains(reflectedWotkItemIdField))
+            {
+                if (found == null) { found = FindReflectedWorkItemByMigrationRef(ReflectedWorkItemId); } // Too slow!
+                //if (found == null) { found = FindReflectedWorkItemByTitle(workItemToFind.Title); }
+            }
             if (found != null) 
             {
-                foundWis.Add(workItemToFind.Id, found);
+                foundWis.Add(workItemToFind.Id, found); /// TODO MENORY LEEK! LEAK
             }
 
             return found;

TfsWitMigrator.Core/MigrationContext/WorkItemMigrationContext.cs

@@ -170,7 +170,14 @@ private static WorkItem CreateAndPopulateWorkItem(WorkItem oldWi, Project destPr
 
 
             // WorkItem newwit = oldWi.Copy(destProject.WorkItemTypes[destType]);
+            var NewWorkItemstartTime = DateTime.UtcNow;
+            Stopwatch NewWorkItemTimer = new Stopwatch();
             WorkItem newwit = destProject.WorkItemTypes[destType].NewWorkItem();
+            NewWorkItemTimer.Stop();
+            Telemetry.Current.TrackDependency("TeamService", "NewWorkItem", NewWorkItemstartTime, NewWorkItemTimer.Elapsed, true);
+            Trace.WriteLine(string.Format("Dependnacy: {0} - {1} - {2} - {3} - {4}", "TeamService", "NewWorkItem", NewWorkItemstartTime, NewWorkItemTimer.Elapsed, true));
+
+
             newwit.Title = oldWi.Title;
             newwit.State = oldWi.State;
             switch (newwit.State)
@@ -253,25 +260,42 @@ private static string ReplaceFirstOccurence(string wordToReplace, string replace
         }
 
 
-        private static void BuildFieldTable(WorkItem oldWi, StringBuilder history)
+        private static void BuildFieldTable(WorkItem oldWi, StringBuilder history, bool useHTML = false)
         {
-            history.Append("<p>&nbsp;</p>");
-            history.Append("<table border='1' cellpadding='2' style='width:100%;border-color:#C0C0C0;'><tr><td><b>Field</b></td><td><b>Value</b></td></tr>");
+            if (useHTML) {
+                history.Append("<p>&nbsp;</p>");
+                history.Append("<table border='1' cellpadding='2' style='width:100%;border-color:#C0C0C0;'><tr><td><b>Field</b></td><td><b>Value</b></td></tr>");
+            }
             foreach (Field f in oldWi.Fields)
             {
                 if (f.Value == null)
                 {
-                    history.AppendFormat("<tr><td style='text-align:right;white-space:nowrap;'><b>{0}</b></td><td>n/a</td></tr>", f.Name);
-
+                    if (useHTML)
+                    {
+                        history.AppendFormat("<tr><td style='text-align:right;white-space:nowrap;'><b>{0}</b></td><td>n/a</td></tr>", f.Name);
+                    } else
+                    {
+                        history.AppendLine(string.Format("{0}: null", f.Name));
+                    }
                 }
                 else
                 {
-                    history.AppendFormat("<tr><td style='text-align:right;white-space:nowrap;'><b>{0}</b></td><td style='width:100%'>{1}</td></tr>", f.Name, f.Value.ToString());
+                    if (useHTML)
+                    {
+                        history.AppendFormat("<tr><td style='text-align:right;white-space:nowrap;'><b>{0}</b></td><td style='width:100%'>{1}</td></tr>", f.Name, f.Value.ToString());
+
+                    }else
+                    {
+                        history.AppendLine(string.Format("{0}: {1}", f.Name, f.Value.ToString()));
+                    }
                 }
 
             }
-            history.Append("</table>");
-            history.Append("<p>&nbsp;</p>");
+            if (useHTML)
+            {
+                history.Append("</table>");
+                history.Append("<p>&nbsp;</p>");
+            }
         }
 
         private static void BuildCommentTable(WorkItem oldWi, StringBuilder history)

TfsWitMigrator.Core/MigrationEngine.cs

@@ -19,6 +19,7 @@ public class MigrationEngine
         ITeamProjectContext source;
         ITeamProjectContext target;
         string reflectedWorkItemIdFieldName = "TfsMigrationTool.ReflectedWorkItemId";
+        
 
         public Dictionary<string, IWitdMapper> WorkItemTypeDefinitions
         {

TfsWitMigrator.Core/Telemetry.cs

@@ -24,12 +24,14 @@ public static TelemetryClient Current { get {
 
         public static void InitiliseTelemetry()
         {
-            Trace.Listeners.Add(new ApplicationInsightsTraceListener(applicationInsightsKey));
+           // Performance? Trace.Listeners.Add(new ApplicationInsightsTraceListener(applicationInsightsKey));
             Microsoft.ApplicationInsights.Extensibility.TelemetryConfiguration.Active.InstrumentationKey = applicationInsightsKey;
             telemetryClient = new TelemetryClient();
             telemetryClient.InstrumentationKey = applicationInsightsKey;
             telemetryClient.Context.User.Id = System.Security.Principal.WindowsIdentity.GetCurrent().Name;
             telemetryClient.Context.Session.Id = Guid.NewGuid().ToString();
+            Trace.WriteLine(string.Format("SessionID: {0}", telemetryClient.Context.Session.Id));
+
         }
     }
 }