Remove UpdateCreatedBy and UpdateCreatedDate options from TfsWorkItemMigrationProcessor and related schemas

Author: MrHinsh

docs/data/classes/reference.processors.tfsworkitemmigrationprocessor.yaml

@@ -59,8 +59,6 @@ configurationSamples:
     {
       "$type": "TfsWorkItemMigrationProcessorOptions",
       "Enabled": false,
-      "UpdateCreatedDate": true,
-      "UpdateCreatedBy": true,
       "WIQLQuery": "SELECT [System.Id] FROM WorkItems WHERE [System.TeamProject] = @TeamProject AND [System.WorkItemType] NOT IN ('Test Suite', 'Test Plan','Shared Steps','Shared Parameter','Feedback Request') ORDER BY [System.ChangedDate] desc",
       "FixHtmlAttachmentLinks": true,
       "WorkItemCreateRetryLimit": 5,
@@ -161,24 +159,6 @@ options:
   defaultValue: missing XML code comments
   isRequired: true
   dotNetType: System.String, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e
-- parameterName: UpdateCreatedBy
-  type: Boolean
-  description: >-
-    If this is enabled the creation process on the target project will create the items with the original creation date.
-     (Important: The item history is always pointed to the date of the migration, it's change only the data column CreateDate,
-     not the internal create date)
-  defaultValue: true
-  isRequired: false
-  dotNetType: System.Boolean, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e
-- parameterName: UpdateCreatedDate
-  type: Boolean
-  description: >-
-    If this is enabled the creation process on the target project will create the items with the original creation date.
-     (Important: The item history is always pointed to the date of the migration, it's change only the data column CreateDate,
-     not the internal create date)
-  defaultValue: true
-  isRequired: false
-  dotNetType: System.Boolean, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e
 - parameterName: WIQLQuery
   type: String
   description: A work item query based on WIQL to select only important work items. To migrate all leave this empty. See [WIQL Query Bits](#wiql-query-bits)

docs/static/schema/configuration.schema.json

@@ -1466,16 +1466,6 @@
                       "description": "This is the `IEndpoint` that will be used as the Target of the Migration. Can be null for a read only processor.",
                       "type": "string"
                     },
-                    "UpdateCreatedBy": {
-                      "description": "If this is enabled the creation process on the target project will create the items with the original creation date.\r\n (Important: The item history is always pointed to the date of the migration, it's change only the data column CreateDate,\r\n not the internal create date)",
-                      "type": "boolean",
-                      "default": "true"
-                    },
-                    "UpdateCreatedDate": {
-                      "description": "If this is enabled the creation process on the target project will create the items with the original creation date.\r\n (Important: The item history is always pointed to the date of the migration, it's change only the data column CreateDate,\r\n not the internal create date)",
-                      "type": "boolean",
-                      "default": "true"
-                    },
                     "WIQLQuery": {
                       "description": "A work item query based on WIQL to select only important work items. To migrate all leave this empty. See [WIQL Query Bits](#wiql-query-bits)",
                       "type": "string",

docs/static/schema/schema.processors.tfsworkitemmigrationprocessor.json

@@ -63,16 +63,6 @@
       "description": "This is the `IEndpoint` that will be used as the Target of the Migration. Can be null for a read only processor.",
       "type": "string"
     },
-    "UpdateCreatedBy": {
-      "description": "If this is enabled the creation process on the target project will create the items with the original creation date.\r\n (Important: The item history is always pointed to the date of the migration, it's change only the data column CreateDate,\r\n not the internal create date)",
-      "type": "boolean",
-      "default": "true"
-    },
-    "UpdateCreatedDate": {
-      "description": "If this is enabled the creation process on the target project will create the items with the original creation date.\r\n (Important: The item history is always pointed to the date of the migration, it's change only the data column CreateDate,\r\n not the internal create date)",
-      "type": "boolean",
-      "default": "true"
-    },
     "WIQLQuery": {
       "description": "A work item query based on WIQL to select only important work items. To migrate all leave this empty. See [WIQL Query Bits](#wiql-query-bits)",
       "type": "string",

src/MigrationTools.Clients.TfsObjectModel/Endpoints/TfsEndpointOptions.cs

@@ -19,17 +19,17 @@ public enum TfsProductVersion
         /// <summary>
         /// Represents legacy Team Foundation Server versions prior to 2013. Not technically supported but may work.
         /// </summary>
-        OnPremisesClassic,
+        OnPremisesClassic = 0,
 
         /// <summary>
         /// Represents on-premises Team Foundation Server 2013+ and Azure DevOps Server (default).
         /// </summary>
-        OnPremises,
+        OnPremises = 1,
 
         /// <summary>
         /// Represents Azure DevOps Services (cloud version).
         /// </summary>
-        Cloud
+        Cloud = 2
     }
 
     /// <summary>

src/MigrationTools.Clients.TfsObjectModel/Processors/TfsWorkItemMigrationProcessor.cs

@@ -369,13 +369,10 @@ private WorkItemData CreateWorkItem_Shell(ProjectData destProject, WorkItemData
                 activity?.Stop();
                 activity?.SetStatus(ActivityStatusCode.Ok);
                 activity?.SetTag("http.response.status_code", "200");
-                if (Options.UpdateCreatedBy)
+                if (Target.Options.ProductVersion != Endpoints.TfsProductVersion.OnPremisesClassic)
                 {
                     newwit.Fields["System.CreatedBy"].Value = currentRevisionWorkItem.ToWorkItem().Revisions[0].Fields["System.CreatedBy"].Value;
                     workItemLog.Debug("Setting 'System.CreatedBy'={SystemCreatedBy}", currentRevisionWorkItem.ToWorkItem().Revisions[0].Fields["System.CreatedBy"].Value);
-                }
-                if (Options.UpdateCreatedDate)
-                {
                     newwit.Fields["System.CreatedDate"].Value = currentRevisionWorkItem.ToWorkItem().Revisions[0].Fields["System.CreatedDate"].Value;
                     workItemLog.Debug("Setting 'System.CreatedDate'={SystemCreatedDate}", currentRevisionWorkItem.ToWorkItem().Revisions[0].Fields["System.CreatedDate"].Value);
                 }

src/MigrationTools.Clients.TfsObjectModel/Processors/TfsWorkItemMigrationProcessorOptions.cs

@@ -11,24 +11,6 @@ namespace MigrationTools.Processors
     /// </summary>
     public class TfsWorkItemMigrationProcessorOptions : ProcessorOptions, IWorkItemProcessorConfig
     {
-        /// <summary>
-        /// If this is enabled the creation process on the target project will create the items with the original creation date.
-        /// (Important: The item history is always pointed to the date of the migration, it's change only the data column CreateDate,
-        /// not the internal create date)
-        /// </summary>
-        /// <default>true</default>
-        [JsonProperty(DefaultValueHandling = DefaultValueHandling.Ignore)]
-        public bool UpdateCreatedDate { get; set; } = true;
-
-        /// <summary>
-        /// If this is enabled the creation process on the target project will create the items with the original creation date.
-        /// (Important: The item history is always pointed to the date of the migration, it's change only the data column CreateDate,
-        /// not the internal create date)
-        /// </summary>
-        /// <default>true</default>
-        [JsonProperty(DefaultValueHandling = DefaultValueHandling.Ignore)]
-        public bool UpdateCreatedBy { get; set; } = true;
-
         /// <summary>
         /// A work item query based on WIQL to select only important work items. To migrate all leave this empty. See [WIQL Query Bits](#wiql-query-bits)
         /// </summary>