PR 24: Fixed bug in field mapp

MrHinsh · MrHinsh · commit bef8431c5a17 · 2016-08-10T09:25:33.000Z
- Fixed bug in field mapp
diff --git a/TfsWitMigrator.Core/FieldMaps/FieldMapBase.cs b/TfsWitMigrator.Core/FieldMaps/FieldMapBase.cs
@@ -22,7 +22,7 @@ public void Execute(WorkItem source, WorkItem target)
                 TelemetryClient tc = new TelemetryClient();
                 tc.TrackException(ex);
                 Trace.TraceWarning(string.Format("  [EXCEPTION] {0}", ex.Message));
-                throw;
+                //throw;
             }            
         }
 
diff --git a/TfsWitMigrator.Core/FieldMaps/FieldToFieldMap.cs b/TfsWitMigrator.Core/FieldMaps/FieldToFieldMap.cs
@@ -21,9 +21,8 @@ public FieldToFieldMap(string sourceField, string targetField)
 
         internal override void InternalExecute(WorkItem source, WorkItem target)
         {
-            if (source.Fields.Contains(sourceField))
+            if (source.Fields.Contains(sourceField) && target.Fields.Contains(targetField))
             {
-                // to tag
                 target.Fields[targetField].Value = source.Fields[sourceField].Value;
                 Trace.WriteLine(string.Format("  [UPDATE] field mapped {0}:{1} to {2}:{3}", source.Id, sourceField, target.Id, targetField));
             }

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public void Execute(WorkItem source, WorkItem target)`
`22`	`22`	`TelemetryClient tc = new TelemetryClient();`
`23`	`23`	`tc.TrackException(ex);`
`24`	`24`	`Trace.TraceWarning(string.Format(" [EXCEPTION] {0}", ex.Message));`
`25`		`- throw;`
	`25`	`+ //throw;`
`26`	`26`	`}`
`27`	`27`	`}`
`28`	`28`
Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,8 @@ public FieldToFieldMap(string sourceField, string targetField)`
`21`	`21`
`22`	`22`	`internal override void InternalExecute(WorkItem source, WorkItem target)`
`23`	`23`	`{`
`24`		`- if (source.Fields.Contains(sourceField))`
	`24`	`+ if (source.Fields.Contains(sourceField) && target.Fields.Contains(targetField))`
`25`	`25`	`{`
`26`		`- // to tag`
`27`	`26`	`target.Fields[targetField].Value = source.Fields[sourceField].Value;`
`28`	`27`	`Trace.WriteLine(string.Format(" [UPDATE] field mapped {0}:{1} to {2}:{3}", source.Id, sourceField, target.Id, targetField));`
`29`	`28`	`}`