Fix accessing non-existing field in target work item (#2880)

MrHinsh · web-flow · commit e68adccbcac4 · 2025-07-09T16:03:39.000+01:00
Fixes #2879
diff --git a/src/MigrationTools.Clients.TfsObjectModel/Processors/TfsWorkItemMigrationProcessor.cs b/src/MigrationTools.Clients.TfsObjectModel/Processors/TfsWorkItemMigrationProcessor.cs
@@ -525,7 +525,10 @@ private void PopulateWorkItem(WorkItemData oldWorkItemData, WorkItemData newWork
             foreach (Field f in oldWorkItem.Fields)
             {
                 CommonTools.UserMapping.MapUserIdentityField(f);
-                CommonTools.UserMapping.MapUserIdentityField(newWorkItem.Fields[f.ReferenceName]);
+                if (newWorkItem.Fields.Contains(f.ReferenceName))
+                {
+                    CommonTools.UserMapping.MapUserIdentityField(newWorkItem.Fields[f.ReferenceName]);
+                }
 
                 if (newWorkItem.Fields.Contains(f.ReferenceName) == false)
                 {

Original file line number	Diff line number	Diff line change
`@@ -525,7 +525,10 @@ private void PopulateWorkItem(WorkItemData oldWorkItemData, WorkItemData newWork`
`525`	`525`	`foreach (Field f in oldWorkItem.Fields)`
`526`	`526`	`{`
`527`	`527`	`CommonTools.UserMapping.MapUserIdentityField(f);`
`528`		`- CommonTools.UserMapping.MapUserIdentityField(newWorkItem.Fields[f.ReferenceName]);`
	`528`	`+ if (newWorkItem.Fields.Contains(f.ReferenceName))`
	`529`	`+ {`
	`530`	`+ CommonTools.UserMapping.MapUserIdentityField(newWorkItem.Fields[f.ReferenceName]);`
	`531`	`+ }`
`529`	`532`
`530`	`533`	`if (newWorkItem.Fields.Contains(f.ReferenceName) == false)`
`531`	`534`	`{`