TargetToTarget with ReflectedWorkItemId

[djbyrd]

I think there is an order of operation issue with TargetToTarget field mapping, specifically with the ReflectedWorkItemId. When using the field mapping as documented in the Test Plan migration guide, it seems the TargetToTarget is happening before the target is updated with the ReflectedWorkItemId. So, my target ends up with a blank IntegrationBuild field. If I re-run the migration then it gets updated the second time around.

[13:47:13 DBG] [16.3.0] Running Field Map: FieldToFieldMap Custom.ReflectedWorkItemId Microsoft.VSTS.Build.IntegrationBuild
[13:47:13 DBG] [16.3.0] FieldToFieldMap: [UPDATE] field mapped S1234:Custom.ReflectedWorkItemId to 0:Microsoft.VSTS.Build.IntegrationBuild as TargetToTarget
[13:47:13 DBG] [16.3.0] Running Field Map: FieldValueMap System.State System.State
[13:47:13 DBG] [16.3.0] FieldValueMap: [UPDATE] field value mapped S1234:System.State to 0:System.State
[13:47:13 DBG] [16.3.0] Running Field Map: FieldValuetoTagMap Custom.Validated
[13:47:13 INF] [16.3.0] EmbededImagesRepairEnricher: Fixing HTML field attachments for work item 0 from https://dev.azure.com/Source/ to https://dev.azure.com/Target/
[13:47:13 INF] [16.3.0] TfsWorkItemEmbededLinkTool: Fixing embedded mention links on target work item 0 from https://dev.azure.com/Source/ to https://dev.azure.com/Target/
[13:47:13 DBG] [16.3.0] CheckClosedDateIsValid::ClosedDate field is Microsoft.VSTS.Common.ClosedDate
[13:47:13 DBG] [16.3.0] TfsExtensions::SaveToAzureDevOps
[13:47:13 DBG] [16.3.0] TfsExtensions::SaveToAzureDevOps: ChangedBy: XXXX, AuthorisedBy: XXXX
[13:47:14 INF] [16.3.0] [ User Story][Complete: 1/1][sid: S1234|Rev: 9][tid: null | Saved TargetWorkItem T7890. Replayed revision 1 of 9
[13:47:14 INF] [16.3.0] [ User Story][Complete: 1/1][sid: S1234|Rev: 9][tid: null | Processing Revision [2]
[13:47:14 DBG] [16.3.0] PopulateWorkItem:FieldUpdate: Custom.ReflectedWorkItemId | Source: Target:https://dev.azure.com/Source/Project/_workitems/edit/S1234

[JDAVF]

@djbyrd Check this PR: #2999 - and my issue: #2996

[MrHinsh]

Ooooo Good Catch....

I dought this is an easy fix, but Ill look

[JDAVF]

I hoped my workaround (add Custom field also to the source) fixed also that issue. But I've got the same problem.
Workaround now is copy the ReflectedWorkItemId afterwards...

[djbyrd]

I can see how they'd originally want the ReflectedWorkItemId to be populated last, to keep it from being overwritten in cases where the source also had that column. But in this case, it needs to be copied before the TargetToTarget field map. If possible, the TargetToTarget field mappings should go after all other processing happens.