FieldMappingTool ignores type-specific mappings when * exists

[ma-chni]

Hi @MrHinsh, @satano

Using version 16.3.3

I’ve noticed that when a wildcard ("*") field map is defined, any type-specific mappings (like "Bug") are ignored. For example, if both exist:

"ApplyTo": ["*"]

and

"ApplyTo": ["Bug"]

Only the "*" mapping is applied, and the "Bug" mapping is never executed.

Is there any way to configure or use the tool so that both the wildcard and type-specific mappings are applied?

[satano]

Yes, I have noticed this couple of weeks ago myself. I do not know it this behavior was really intended and so it is by design, or it is some historic mistake. Because I personally think this is not what would people expect (at least not me). My opinion is, that type-specific mapping should have just precedence. So first type-specific mapping is looked up. If found it is used. If not found, wildcard * mapping is looked up.

I would be happy to change this, but the decision is not up to me. 🙂

[satano]

Oh. I checked the history and it seems it is my own mistake made in this commit. 😳

I will look at it as soon as I will have a bit of time. Sorry for inconvinience. ☹️

[ma-chni]

I had a look at it and it seems to be working fine with this change @satano

        public List<IFieldMap> GetFieldMappings(string witName)
        {
            var result = new List<IFieldMap>();
            if (_fieldMaps.TryGetValue("*", out var globalMaps))
            {
                result.AddRange(globalMaps);
            }
            if (_fieldMaps.TryGetValue(witName, out var specificMaps))
            {
                result.AddRange(specificMaps);
            }
            return result;
        }

[MrHinsh]

#3060