fix(generator): background typings incorrect

nklayman · nklayman · commit 27ee3777fe80 · 2019-02-24T19:39:40.000-08:00
diff --git a/generator/index.js b/generator/index.js
@@ -44,7 +44,7 @@ module.exports = (api, options = {}) => {
         /process\.env\.WEBPACK_DEV_SERVER_URL\s*?\)$/m,
         'process.env.WEBPACK_DEV_SERVER_URL as string)'
       )
-      background = background.replace(/let win\s*?$/m, 'let win: BrowserWindow')
+      background = background.replace(/let win\s*?$/m, 'let win: BrowserWindow | null')
       fs.writeFileSync(api.resolve('./src/background.ts'), background)
       if (api.hasPlugin('router')) {
         console.log('\n')

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ module.exports = (api, options = {}) => {`
`44`	`44`	`/process\.env\.WEBPACK_DEV_SERVER_URL\s*?\)$/m,`
`45`	`45`	`'process.env.WEBPACK_DEV_SERVER_URL as string)'`
`46`	`46`	`)`
`47`		`- background = background.replace(/let win\s*?$/m, 'let win: BrowserWindow')`
	`47`	`+ background = background.replace(/let win\s*?$/m, 'let win: BrowserWindow \| null')`
`48`	`48`	`fs.writeFileSync(api.resolve('./src/background.ts'), background)`
`49`	`49`	`if (api.hasPlugin('router')) {`
`50`	`50`	`console.log('\n')`