fix(generator/background): disable contextIsolation when nodeIntegration is enabled

nklayman · nklayman · commit 2b3ec0259a60 · 2021-03-08T15:38:05.000-08:00
fixes #1279
diff --git a/generator/templates/base/src/background.js b/generator/templates/base/src/background.js
@@ -22,7 +22,8 @@ async function createWindow() {
       <% } %>
       // Use pluginOptions.nodeIntegration, leave this alone
       // See nklayman.github.io/vue-cli-plugin-electron-builder/guide/security.html#node-integration for more info
-      nodeIntegration: process.env.ELECTRON_NODE_INTEGRATION
+      nodeIntegration: process.env.ELECTRON_NODE_INTEGRATION,
+      contextIsolation: !process.env.ELECTRON_NODE_INTEGRATION
     }
   })
 

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,8 @@ async function createWindow() {`
`22`	`22`	`<% } %>`
`23`	`23`	`// Use pluginOptions.nodeIntegration, leave this alone`
`24`	`24`	`// See nklayman.github.io/vue-cli-plugin-electron-builder/guide/security.html#node-integration for more info`
`25`		`- nodeIntegration: process.env.ELECTRON_NODE_INTEGRATION`
	`25`	`+ nodeIntegration: process.env.ELECTRON_NODE_INTEGRATION,`
	`26`	`+ contextIsolation: !process.env.ELECTRON_NODE_INTEGRATION`
`26`	`27`	`}`
`27`	`28`	`})`
`28`	`29`