fix(devtools): installVueDevtools() not returning a promise, closes #122

nklayman · nklayman · commit 4ea1553b45cd · 2018-10-26T10:16:25.000-07:00
diff --git a/generator/template/src/background.js b/generator/template/src/background.js
@@ -55,7 +55,7 @@ app.on('activate', () => {
 app.on('ready', async () => {
   if (isDevelopment && !process.env.IS_TEST) {
     // Install Vue Devtools
-    installVueDevtools()
+    await installVueDevtools()
   }
   createWindow()
 })
diff --git a/lib/installVueDevtools/index.js b/lib/installVueDevtools/index.js
@@ -28,7 +28,7 @@ const install = (forceDownload = false) => {
       BrowserWindow.getDevToolsExtensions &&
       BrowserWindow.getDevToolsExtensions()[extensionName]
     if (!forceDownload && extensionInstalled) {
-      return Promise.resolve(IDMap[chromeStoreID])
+      return resolve(IDMap[chromeStoreID])
     }
     downloadChromeExtension(chromeStoreID, forceDownload).then(
       extensionFolder => {

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ app.on('activate', () => {`
`55`	`55`	`app.on('ready', async () => {`
`56`	`56`	`if (isDevelopment && !process.env.IS_TEST) {`
`57`	`57`	`// Install Vue Devtools`
`58`		`- installVueDevtools()`
	`58`	`+ await installVueDevtools()`
`59`	`59`	`}`
`60`	`60`	`createWindow()`
`61`	`61`	`})`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ const install = (forceDownload = false) => {`
`28`	`28`	`BrowserWindow.getDevToolsExtensions &&`
`29`	`29`	`BrowserWindow.getDevToolsExtensions()[extensionName]`
`30`	`30`	`if (!forceDownload && extensionInstalled) {`
`31`		`- return Promise.resolve(IDMap[chromeStoreID])`
	`31`	`+ return resolve(IDMap[chromeStoreID])`
`32`	`32`	`}`
`33`	`33`	`downloadChromeExtension(chromeStoreID, forceDownload).then(`
`34`	`34`	`extensionFolder => {`