Skip to content

Commit 91d040f

Browse files
committed
fix(tests): flush promises on relaunch tests
1 parent 1bbb247 commit 91d040f

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

__tests__/commands.spec.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,7 @@ describe('electron:serve', () => {
510510
expect(mainConfig.node.shouldBe).toBe('expected')
511511
})
512512

513-
test('Custom launch arguments is used if provided', async () => {
513+
test('Custom launch arguments are used if provided', async () => {
514514
let watchCb
515515
chokidar.watch.mockImplementation(() => {
516516
return {
@@ -545,6 +545,8 @@ describe('electron:serve', () => {
545545
watchCb()
546546
// Call exit callback because app should have quit
547547
await exitCb()
548+
// Flush promises, only required on node v10 for some reason
549+
await (() => new Promise(resolve => setImmediate(resolve)))()
548550
expect(mockExeca.removeListener.mock.calls[0][0]).toBe('exit')
549551

550552
expect(execa).toHaveBeenCalledTimes(2)
@@ -626,6 +628,8 @@ describe('electron:serve', () => {
626628
watchCb()
627629
// Call exit callback because app should have quit
628630
await exitCb()
631+
// Flush promises, only required on node v10 for some reason
632+
await (() => new Promise(resolve => setImmediate(resolve)))()
629633
expect(mockExeca.removeListener.mock.calls[0][0]).toBe('exit')
630634
// Electron was killed and listeners removed
631635
if (isWin) {
@@ -690,6 +694,8 @@ describe('electron:serve', () => {
690694
watchCb['projectPath/listFile']()
691695
// Call exit callback because app should have quit
692696
await exitCb()
697+
// Flush promises, only required on node v10 for some reason
698+
await (() => new Promise(resolve => setImmediate(resolve)))()
693699
expect(mockExeca.removeListener.mock.calls[0][0]).toBe('exit')
694700
// Electron was killed and listeners removed
695701
if (isWin) {
@@ -714,6 +720,8 @@ describe('electron:serve', () => {
714720
watchCb['projectPath/customBackground']()
715721
// Call exit callback because app should have quit
716722
await exitCb()
723+
// Flush promises, only required on node v10 for some reason
724+
await (() => new Promise(resolve => setImmediate(resolve)))()
717725
expect(mockExeca.removeListener.mock.calls[0][0]).toBe('exit')
718726
// Electron was killed and listeners removed
719727
if (isWin) {

0 commit comments

Comments
 (0)