fix(build): fails with multiple pages, closes 182

Author: nklayman

__tests__/commands.spec.js

@@ -317,6 +317,35 @@ describe('electron:build', () => {
     expect(options.baseUrl).toBe('expected')
     expect(options.publicPath).toBe('expected')
   })
+
+  test('Adds mock legacy assets file for index', async () => {
+    await runCommand('electron:build')
+    expect(fs.writeFileSync).toBeCalledWith(
+      'dist_electron/bundled/legacy-assets-index.html.json',
+      '[]'
+    )
+  })
+
+  test.each(['string config', 'object config'])(
+    'Adds mock legacy assets file for each page (%s)',
+    async configType => {
+      const stringConfig = configType === 'string config'
+      await runCommand('electron:build', {
+        pages: {
+          index: stringConfig ? '' : { fileName: 'index.html' },
+          subpage: stringConfig ? '' : { fileName: 'subpage.html' }
+        }
+      })
+      expect(fs.writeFileSync).toBeCalledWith(
+        'dist_electron/bundled/legacy-assets-index.html.json',
+        '[]'
+      )
+      expect(fs.writeFileSync).toBeCalledWith(
+        'dist_electron/bundled/legacy-assets-subpage.html.json',
+        '[]'
+      )
+    }
+  )
 })
 
 describe('electron:serve', () => {

index.js

@@ -111,10 +111,17 @@ module.exports = (api, options) => {
           fs.removeSync(bundleOutputDir)
           fs.ensureDirSync(bundleOutputDir)
           // Mock data from legacy build
-          fs.writeFileSync(
-            path.join(bundleOutputDir, 'legacy-assets-index.html.json'),
-            '[]'
-          )
+          const pages = options.pages || { index: '' }
+          Object.keys(pages).forEach(page => {
+            if (pages[page].fileName) {
+              // If page is configured as an object, use the filename (without .html)
+              page = pages[page].fileName.replace(/\.html$/, '')
+            }
+            fs.writeFileSync(
+              path.join(bundleOutputDir, `legacy-assets-${page}.html.json`),
+              '[]'
+            )
+          })
           //   Set the base url so that the app protocol is used
           options.baseUrl = pluginOptions.customFileProtocol || 'app://./'
           // Set publicPath as well (replaced baseUrl since @vue/cli 3.3.0)