feat(webpack): always use new native dep checker

Author: nklayman

lib/webpackConfig.js

@@ -110,68 +110,39 @@ function getExternals (api, pluginOptions) {
   )
   const externalsList = allDependencies.reduce((depList, dep) => {
     try {
-      if (process.env.VCPEB_EXPERIMENTAL_NATIVE_DEP_CHECK) {
-        // If dep is in whitelist, don't add it no matter what
-        if (userExternalsWhitelist.includes(dep)) {
-          return depList
-        }
-        const name = userExternals.find((name) =>
-          new RegExp(`^${dep}(/|$)`).test(name)
-        )
-        // If dep is listed in user external array, it is an external
-        if (name) {
+      // If dep is in whitelist, don't add it no matter what
+      if (userExternalsWhitelist.includes(dep)) {
+        return depList
+      }
+      const name = userExternals.find((name) =>
+        new RegExp(`^${dep}(/|$)`).test(name)
+      )
+      // If dep is listed in user external array, it is an external
+      if (name) {
+        // Use user-provided name if it exists to support subpaths
+        depList.push(name || dep)
+        return depList
+      }
+      for (const path of nodeModulesPaths) {
+        // Check if binding.gyp exists
+        if (fs.existsSync(api.resolve(`${path}/${dep}/binding.gyp`))) {
+          // If it does, dep is native
           // Use user-provided name if it exists to support subpaths
           depList.push(name || dep)
           return depList
         }
-        for (const path of nodeModulesPaths) {
-          // Check if binding.gyp exists
-          if (fs.existsSync(api.resolve(`${path}/${dep}/binding.gyp`))) {
-            // If it does, dep is native
-            // Use user-provided name if it exists to support subpaths
-            depList.push(name || dep)
-            return depList
-          }
-        }
-      } else {
-        let pgkString
-        for (const path of nodeModulesPaths) {
-          // Check if package.json exists
-          if (fs.existsSync(api.resolve(`${path}/${dep}/package.json`))) {
-            // If it does, read it and break
-            pgkString = fs
-              .readFileSync(api.resolve(`${path}/${dep}/package.json`))
-              .toString()
-            break
-          }
-        }
-        if (!pgkString) {
-          throw new Error(`Could not find a package.json for module ${dep}`)
-        }
-        const pkg = JSON.parse(pgkString)
-        const name = userExternals.find((name) =>
-          new RegExp(`^${pkg.name}(/|$)`).test(name)
-        )
-        const fields = ['main', 'module', 'jsnext:main', 'browser']
-        if (
-          // Not whitelisted
-          userExternalsWhitelist.indexOf(dep) === -1 &&
-          // Doesn't have main property
-          (!fields.some((field) => field in pkg) ||
-            // Has binary property
-            !!pkg.binary ||
-            // Has gypfile property
-            !!pkg.gypfile ||
-            // Listed in user-defined externals list
-            !!name)
-        ) {
-          // Use user-provided name if it exists, for subpaths
-          depList.push(name || dep)
-        }
       }
     } catch (e) {
-      console.log(e)
-      depList.push(dep)
+      error(
+        `An error occurred while trying to determine if dependecy "${dep}" is native:`,
+        e
+      )
+      error(
+        'Please manually specify the dependency in the "externals" option, prefixing with a "!" if it should not be externalized.'
+      )
+      error(
+        'See https://nklayman.github.io/vue-cli-plugin-electron-builder/guide/guide.html#native-modules for more details.'
+      )
     }
     return depList
   }, [])