fix(build): VUE_APP env vars not available in build

Author: nklayman

__tests__/commands.spec.js

@@ -273,7 +273,7 @@ describe('electron:build', () => {
 
   test('Env vars prefixed with VUE_APP_ are available in main process config', async () => {
     process.env.VUE_APP_TEST = 'expected'
-    await runCommand('electron:serve')
+    await runCommand('electron:build')
     const mainConfig = webpack.mock.calls[0][0]
     // Env var is set correctly
     expect(mainConfig.plugins[1].defaultValues.VUE_APP_TEST).toBe('expected')

index.js

@@ -501,6 +501,7 @@ function bundleMain ({
     .path(api.resolve(outputDir + (isBuild ? '/bundled' : '')))
     // Electron will not detect background.js on dev server, only index.js
     .filename('[name].js')
+  const envVars = {}
   if (isBuild) {
     //   Set __static to __dirname (files in public get copied here)
     config
@@ -513,20 +514,19 @@ function bundleMain ({
         __static: JSON.stringify(api.resolve('./public'))
       }
     ])
-    const envVars = {
-      // Dev server url
-      WEBPACK_DEV_SERVER_URL: server.url,
-      // Path to node_modules (for externals in development)
-      NODE_MODULES_PATH: api.resolve('./node_modules')
-    }
-    // Add all env vars prefixed with VUE_APP_
-    Object.keys(process.env).forEach(k => {
-      if (/^VUE_APP_/.test(k)) {
-        envVars[k] = process.env[k]
-      }
-    })
-    config.plugin('env').use(webpack.EnvironmentPlugin, [envVars])
+    // Dev server url
+    envVars['WEBPACK_DEV_SERVER_URL'] = server.url
+    // Path to node_modules (for externals in development)
+    envVars['NODE_MODULES_PATH'] = api.resolve('./node_modules')
   }
+  // Add all env vars prefixed with VUE_APP_
+  Object.keys(process.env).forEach(k => {
+    if (/^VUE_APP_/.test(k)) {
+      envVars[k] = process.env[k]
+    }
+  })
+  config.plugin('env').use(webpack.EnvironmentPlugin, [envVars])
+
   if (args.debug) {
     // Enable source maps for debugging
     config.devtool('source-map')