Skip to content

Commit 39d534e

Browse files
committed
Normalize tool selection assertions to be case-insensitive for improved accuracy
1 parent ff617d6 commit 39d534e

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

tests/NLWebNet.Tests/Services/ToolSelectionAccuracyTests.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public async Task ToolSelection_CompareQueries_SelectCompareToolCorrectly()
6060
if (scenario.ExpectedTools.Contains("Compare"))
6161
{
6262
// For compare scenarios, the tool selector should select the "compare" tool
63-
Assert.AreEqual("compare", selectedTool,
63+
Assert.AreEqual("compare", selectedTool?.ToLowerInvariant(),
6464
$"Expected 'compare' tool to be selected for compare query: '{scenario.Query}'");
6565
Console.WriteLine($"✓ Compare tool correctly selected for: {scenario.Query}");
6666
}
@@ -100,14 +100,14 @@ public async Task ToolSelection_DetailQueries_SelectDetailsToolCorrectly()
100100

101101
if (shouldSelectDetails)
102102
{
103-
Assert.AreEqual("details", selectedTool,
103+
Assert.AreEqual("details", selectedTool?.ToLowerInvariant(),
104104
$"Expected 'details' tool to be selected for details query: '{scenario.Query}'");
105105
Console.WriteLine($"✓ Details tool correctly selected for: {scenario.Query}");
106106
}
107107
else
108108
{
109109
// Query doesn't contain details keywords, so it defaults to search
110-
Assert.AreEqual("search", selectedTool,
110+
Assert.AreEqual("search", selectedTool?.ToLowerInvariant(),
111111
$"Expected 'search' tool (default) for query without details keywords: '{scenario.Query}'");
112112
Console.WriteLine($"✓ Search tool (default) correctly selected for: {scenario.Query}");
113113
}
@@ -149,14 +149,14 @@ public async Task ToolSelection_EnsembleQueries_SelectToolsCorrectly()
149149

150150
if (shouldSelectEnsemble)
151151
{
152-
Assert.AreEqual("ensemble", selectedTool,
152+
Assert.AreEqual("ensemble", selectedTool?.ToLowerInvariant(),
153153
$"Expected 'ensemble' tool to be selected for ensemble query: '{scenario.Query}'");
154154
Console.WriteLine($"✓ Ensemble tool correctly selected for: {scenario.Query}");
155155
}
156156
else
157157
{
158158
// Query doesn't contain ensemble keywords, so it defaults to search
159-
Assert.AreEqual("search", selectedTool,
159+
Assert.AreEqual("search", selectedTool?.ToLowerInvariant(),
160160
$"Expected 'search' tool (default) for query without ensemble keywords: '{scenario.Query}'");
161161
Console.WriteLine($"✓ Search tool (default) correctly selected for: {scenario.Query}");
162162
}
@@ -193,7 +193,7 @@ public async Task ToolSelection_BasicSearchQueries_HandleAppropriately()
193193
if (scenario.ExpectedTools.Contains("Search"))
194194
{
195195
// For basic search scenarios, the tool selector should select the "search" tool or null
196-
Assert.IsTrue(selectedTool == "search" || selectedTool == null,
196+
Assert.IsTrue(selectedTool?.ToLowerInvariant() == "search" || selectedTool == null,
197197
$"Expected 'search' tool or null to be selected for basic search query: '{scenario.Query}', but got: {selectedTool}");
198198
Console.WriteLine($"✓ Basic search tool selection validated: {selectedTool ?? "null"} for '{scenario.Query}'");
199199
}

0 commit comments

Comments
 (0)