Address PR feedback: improve script robustness, add resource limits, and fix GitHub Actions

Co-authored-by: jongalloway <[email protected]>

Author: Copilot

.github/workflows/build.yml

@@ -438,8 +438,8 @@ jobs:
         echo "" >> $GITHUB_STEP_SUMMARY
         echo "### Usage" >> $GITHUB_STEP_SUMMARY
         echo "\`\`\`bash" >> $GITHUB_STEP_SUMMARY
-        echo "docker pull ghcr.io/${{ github.repository }}/demo:latest" >> $GITHUB_STEP_SUMMARY
-        echo "docker run -p 8080:8080 ghcr.io/${{ github.repository }}/demo:latest" >> $GITHUB_STEP_SUMMARY
+        echo "docker pull ${{ steps.meta.outputs.tags }}" >> $GITHUB_STEP_SUMMARY
+        echo "docker run -p 8080:8080 ${{ steps.meta.outputs.tags }}" >> $GITHUB_STEP_SUMMARY
         echo "\`\`\`" >> $GITHUB_STEP_SUMMARY
 
   # Alternative: .NET SDK Container Build (modern approach)

deployment/docker/build-docker.sh

@@ -2,7 +2,7 @@
 # Build script for Docker container in environments with SSL issues
 # This script prepares a build-ready environment and builds the Docker image
 
-set -e
+set -euo pipefail
 
 echo "🔧 Building NLWebNet Docker image with SSL workarounds..."
 
@@ -19,31 +19,11 @@ dotnet restore
 # Build the Docker image with appropriate strategy based on environment
 echo "🐳 Building Docker image..."
 
-# Try the standard approach first
+# Build the Docker image
 if docker build -f deployment/docker/Dockerfile . -t nlwebnet-demo:latest; then
-    echo "✅ Docker build successful with standard approach"
-elif [ -f "deployment/docker/Dockerfile.pre-built" ]; then
-    echo "⚠️ Standard build failed, trying pre-built approach..."
-    # Use the pre-built approach if available
-    cp deployment/docker/.dockerignore-prebuilt .dockerignore.backup
-    mv .dockerignore .dockerignore.original
-    cp deployment/docker/.dockerignore-prebuilt .dockerignore
-    
-    if docker build -f deployment/docker/Dockerfile.pre-built . -t nlwebnet-demo:latest; then
-        echo "✅ Docker build successful with pre-built approach"
-    else
-        echo "❌ Both build approaches failed"
-        # Restore original .dockerignore
-        mv .dockerignore.original .dockerignore
-        rm -f .dockerignore.backup
-        exit 1
-    fi
-    
-    # Restore original .dockerignore
-    mv .dockerignore.original .dockerignore
-    rm -f .dockerignore.backup
+    echo "✅ Docker build successful"
 else
-    echo "❌ Docker build failed and no fallback available"
+    echo "❌ Docker build failed"
     exit 1
 fi
 

deployment/docker/smoke-test.sh

@@ -2,7 +2,7 @@
 # Smoke test script for NLWebNet Docker container
 # Tests basic functionality and health endpoints
 
-set -e
+set -euo pipefail
 
 CONTAINER_NAME="nlwebnet-test-$(date +%s)"
 CONTAINER_PORT="8080"
@@ -25,7 +25,7 @@ trap cleanup EXIT
 
 # Start the container
 echo "🚀 Starting container..."
-if ! docker run -d --name "$CONTAINER_NAME" -p "$HOST_PORT:$CONTAINER_PORT" "$IMAGE_NAME"; then
+if ! docker run -d --name "$CONTAINER_NAME" -p "$HOST_PORT:$CONTAINER_PORT" --memory=512m --cpus=1 "$IMAGE_NAME"; then
     echo "❌ Failed to start container"
     exit 1
 fi
@@ -57,11 +57,11 @@ sleep 5
 
 # Test basic health endpoint
 echo "🔍 Testing health endpoint..."
-if curl -f -s "http://localhost:$HOST_PORT/health" >/dev/null; then
+if curl --max-time 10 -f -s "http://localhost:$HOST_PORT/health" >/dev/null; then
     echo "✅ Health endpoint responds successfully"
 
     # Get and display health response
-    health_response=$(curl -s "http://localhost:$HOST_PORT/health")
+    health_response=$(curl --max-time 10 -s "http://localhost:$HOST_PORT/health")
     echo "📊 Health response: $health_response"
 else
     echo "❌ Health endpoint failed"
@@ -72,27 +72,27 @@ fi
 
 # Test if detailed health endpoint exists
 echo "🔍 Testing detailed health endpoint..."
-if curl -f -s "http://localhost:$HOST_PORT/health/detailed" >/dev/null; then
+if curl --max-time 10 -f -s "http://localhost:$HOST_PORT/health/detailed" >/dev/null; then
     echo "✅ Detailed health endpoint responds successfully"
-    detailed_health=$(curl -s "http://localhost:$HOST_PORT/health/detailed")
+    detailed_health=$(curl --max-time 10 -s "http://localhost:$HOST_PORT/health/detailed")
     echo "📊 Detailed health response: $detailed_health"
 else
     echo "⚠️ Detailed health endpoint not available or failed (this may be expected)"
 fi
 
 # Test basic root endpoint
 echo "🔍 Testing root endpoint..."
-if curl -f -s "http://localhost:$HOST_PORT/" >/dev/null; then
+if curl --max-time 10 -f -s "http://localhost:$HOST_PORT/" >/dev/null; then
     echo "✅ Root endpoint responds successfully"
 else
     echo "⚠️ Root endpoint failed (this may be expected for API-only services)"
 fi
 
 # Test if NLWebNet API endpoints are available
 echo "🔍 Testing NLWebNet API endpoints..."
-if curl -f -s "http://localhost:$HOST_PORT/api/nlweb" >/dev/null 2>&1; then
+if curl --max-time 10 -f -s "http://localhost:$HOST_PORT/api/nlweb" >/dev/null 2>&1; then
     echo "✅ NLWebNet API endpoint responds"
-elif curl -f -s "http://localhost:$HOST_PORT/nlweb" >/dev/null 2>&1; then
+elif curl --max-time 10 -f -s "http://localhost:$HOST_PORT/nlweb" >/dev/null 2>&1; then
     echo "✅ NLWebNet endpoint responds"
 else
     echo "⚠️ NLWebNet API endpoints may not be available or configured differently"