Skip to content

Commit 6dac9c4

Browse files
committed
Fix Inconsistent results with HLA- prefix
1 parent f034eb8 commit 6dac9c4

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

pyard/pyard.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -392,11 +392,14 @@ def redux(self, allele: str, ars_type: str) -> str:
392392
:rtype: str
393393
"""
394394

395-
# PERFORMANCE: precompiled regex
396-
# dealing with leading 'HLA-'
395+
# deal with leading 'HLA-'
397396
if self.HLA_regex.search(allele):
398397
hla, allele_name = allele.split("-")
399-
return "-".join(["HLA", self.redux(allele_name, ars_type)])
398+
redux_allele = self.redux(allele_name, ars_type)
399+
if redux_allele:
400+
return "HLA-" + redux_allele
401+
else:
402+
return redux_allele
400403

401404
# Alleles ending with P or G are valid
402405
if allele.endswith(('P', 'G')):

tests/test_pyard.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,3 +76,5 @@ def test_redux_gl(self):
7676

7777
def test_mac_G(self):
7878
self.assertEqual(self.ard.redux("A*01:01:01", 'G'), "A*01:01:01G")
79+
self.assertEqual(self.ard.redux_gl("HLA-A*01:AB", "G"), "HLA-A*01:01:01G/HLA-A*01:02")
80+
self.assertEqual(self.ard.redux("HLA-A*01:AB", "G"), "")

0 commit comments

Comments
 (0)