Skip to content

Commit ab2b7b2

Browse files
authored
Merge pull request #197 from pbashyal-nmdp/3130_rename_to_3131
Special case 3130->3131 version of allelelist.txt
2 parents 09cad4e + 5c7c132 commit ab2b7b2

File tree

5 files changed

+20
-12
lines changed

5 files changed

+20
-12
lines changed

api-spec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ openapi: 3.0.3
22
info:
33
title: ARD Reduction
44
description: Reduce to ARD Level
5-
version: "0.9.0"
5+
version: "0.9.1"
66
servers:
77
- url: 'http://localhost:8080'
88
tags:

pyard/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@
2525
from .blender import blender as dr_blender
2626

2727
__author__ = """NMDP Bioinformatics"""
28-
__version__ = "0.9.0"
28+
__version__ = "0.9.1"

pyard/data_repository.py

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,13 @@
2020
# > http://www.fsf.org/licensing/licenses/lgpl.html
2121
# > http://www.opensource.org/licenses/lgpl-license.php
2222
#
23+
import sys
2324
import copy
2425
from collections import namedtuple
2526
import functools
2627
import sqlite3
28+
from urllib.error import HTTPError
29+
2730
import pandas as pd
2831

2932
from . import db
@@ -334,10 +337,21 @@ def generate_alleles_and_xx_codes_and_who(
334337
if imgt_version == "Latest":
335338
allele_list_url = f"{IMGT_HLA_URL}Latest/Allelelist.txt"
336339
else:
340+
if imgt_version == "3130":
341+
# 3130 was renamed to 3131 for Allelelist file only 🤷🏾‍
342+
imgt_version = "3131"
337343
allele_list_url = (
338344
f"{IMGT_HLA_URL}Latest/allelelist/Allelelist.{imgt_version}.txt"
339345
)
340-
allele_df = pd.read_csv(allele_list_url, header=6, usecols=["Allele"])
346+
347+
try:
348+
allele_df = pd.read_csv(allele_list_url, header=6, usecols=["Allele"])
349+
except HTTPError as e:
350+
print(
351+
f"Failed importing alleles for version {imgt_version} from {allele_list_url}",
352+
file=sys.stderr,
353+
)
354+
sys.exit(1)
341355

342356
# Create a set of valid alleles
343357
# All 2-field, 3-field and the original Alleles are considered valid alleles

setup.cfg

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[bumpversion]
2-
current_version = 0.9.0
2+
current_version = 0.9.1
33
commit = True
44
tag = True
55

@@ -19,10 +19,4 @@ replace = version: "{new_version}"
1919
universal = 1
2020

2121
[flake8]
22-
exclude =
23-
venv,
24-
.git,
25-
__pycache__,
26-
build,
27-
dist,
28-
docs
22+
exclude = venv, .git, __pycache__, build, dist, docs

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
setup(
4141
name="py-ard",
42-
version="0.9.0",
42+
version="0.9.1",
4343
description="ARD reduction for HLA with Python",
4444
long_description=readme + "\n\n" + history,
4545
long_description_content_type="text/markdown",

0 commit comments

Comments
 (0)