changed the code a bit according to Omer's requests. Doesn't effect results. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndle full path. Also now we're passing the em_mr/hap_pop_pair value in grim.grim in impute function. Then in grim.run_impute_def also add at the end of the values in the function ,hap_pop_pair = False,graph =None. Then we're returning the graph at the end. In the middle of the function we're creating the graph if it's None.
Contributor
|
does this address issue #28 ? |
pbashyal-nmdp
approved these changes
Jan 2, 2025
pbashyal-nmdp
merged commit 03dc485
into
nmdp-bioinformatics:master
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the grim.run_impute function in the run_impute_def file to handle full path. Also now we're passing the em_mr/hap_pop_pair value in grim.grim in impute function. Then in grim.run_impute_def also add at the end of the values in the function ,hap_pop_pair = False,graph =None. Then we're returning the graph at the end. In the middle of the function we're creating the graph if it's None.