More attempts to get rid of NDEBUG

Author: michaelbautin

.github/workflows/build.yml

@@ -104,6 +104,7 @@ jobs:
           fi
           "${cmake_cmd[@]}"
 
+          cat CMakeCache.txt
           if [[ "${RUNNER_OS}" == "Windows" ]]; then
             cmake --build ./ --config RelWithDebInfo --verbose
           else

CMakeLists.txt

@@ -138,6 +138,8 @@ endif()
 foreach(NDEBUG_FLAG_STR IN ITEMS "/D NDEBUG" "-DNDEBUG")
     string(REPLACE "${NDEBUG_FLAG_STR}" "" CMAKE_CXX_FLAGS_RELWITHDEBINFO
            "${CMAKE_CXX_FLAGS_RELWITHDEBINFO}")
+    # TODO: this should not be necessary.
+    string(APPEND CMAKE_CXX_FLAGS_RELWITHDEBINFO " -UNDEBUG")
     if(CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")
         string(REPLACE "${NDEBUG_FLAG_STR}" "" CMAKE_CXX_FLAGS
                "${CMAKE_CXX_FLAGS}")

examples/cpp/example_search.cpp

@@ -54,5 +54,10 @@ int main() {
 
     delete[] data;
     delete alg_hnsw;
+#ifdef _MSC_VER
+    // Remove this once we make sure that assertions work correctly in MSVC
+    // RelWithDebInfo builds.
+    assert(false);
+#endif    
     return 0;
 }