See if our approach for removing /EHsc flag is excessive

Author: michaelbautin

CMakeLists.txt

@@ -133,17 +133,10 @@ endif()
 foreach(NDEBUG_FLAG_STR IN ITEMS "/DNDEBUG" "/D NDEBUG" "-DNDEBUG")
     string(REPLACE "${NDEBUG_FLAG_STR}" "" CMAKE_CXX_FLAGS_RELWITHDEBINFO
            "${CMAKE_CXX_FLAGS_RELWITHDEBINFO}")
-    #if(CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")
-    #    string(REPLACE "${NDEBUG_FLAG_STR}" "" CMAKE_CXX_FLAGS
-    #           "${CMAKE_CXX_FLAGS}")
-    #endif()
 endforeach()
+string(STRIP "${CMAKE_CXX_FLAGS_RELWITHDEBINFO}" CMAKE_CXX_FLAGS_RELWITHDEBINFO)
 set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CMAKE_CXX_FLAGS_RELWITHDEBINFO}"
     CACHE STRING "Flags for RelWithDebInfo configuration." FORCE)
-#if(CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")
-#    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}"
-#        CACHE STRING "CMake C++ flags" FORCE)
-#endif()
 
 if(HNSWLIB_EXAMPLES)
     message("Building examples and tests")
@@ -180,7 +173,7 @@ if(HNSWLIB_EXAMPLES)
                 set(${FLAGS_VAR} "${${FLAGS_VAR}}" CACHE STRING
                     "Flags for ${config} configuration." FORCE)
             endforeach()
-            string(REPLACE "/EHsc" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
+            # string(REPLACE "/EHsc" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
         endif()
         add_cxx_flags(/O2 /W1 /openmp)
     endif()