Support error handling without exceptions

Author: michaelbautin

examples/cpp/example_epsilon_search.cpp

@@ -53,8 +53,7 @@ int main() {
         }
         std::cout << "Query #" << i << "\n";
         hnswlib::EpsilonSearchStopCondition<dist_t> stop_condition(epsilon2, min_num_candidates, max_elements);
-        std::vector<std::pair<float, hnswlib::labeltype>> result = 
-            alg_hnsw->searchStopConditionClosest(query_data, stop_condition);
+        HNSWLIB_ASSIGN_VALUE_OR_THROW_IN_TEST(result, alg_hnsw->searchStopConditionClosest(query_data, stop_condition));
         size_t num_vectors = result.size();
         std::cout << "Found " << num_vectors << " vectors\n";
         delete[] query_data;

examples/cpp/example_filter.cpp

@@ -45,7 +45,8 @@ int main() {
     // Query the elements for themselves with filter and check returned labels
     int k = 10;
     for (int i = 0; i < max_elements; i++) {
-        std::vector<std::pair<float, hnswlib::labeltype>> result = alg_hnsw->searchKnnCloserFirst(data + i * dim, k, &pickIdsDivisibleByTwo);
+        HNSWLIB_ASSIGN_VALUE_OR_THROW_IN_TEST(
+            result, alg_hnsw->searchKnnCloserFirst(data + i * dim, k, &pickIdsDivisibleByTwo));
         for (auto item: result) {
             if (item.second % 2 == 1) std::cout << "Error: found odd label\n";
         }

examples/cpp/example_mt_filter.cpp

@@ -106,7 +106,9 @@ int main() {
     int k = 10;
     std::vector<hnswlib::labeltype> neighbors(max_elements * k);
     ParallelFor(0, max_elements, num_threads, [&](size_t row, size_t threadId) {
-        std::priority_queue<std::pair<float, hnswlib::labeltype>> result = alg_hnsw->searchKnn(data + dim * row, k, &pickIdsDivisibleByTwo);
+        HNSWLIB_ASSIGN_VALUE_OR_THROW_IN_TEST(
+            result,
+            alg_hnsw->searchKnn(data + dim * row, k, &pickIdsDivisibleByTwo));
         for (int i = 0; i < k; i++) {
             hnswlib::labeltype label = result.top().second;
             result.pop();

examples/cpp/example_mt_search.cpp

@@ -89,7 +89,7 @@ int main() {
     // Query the elements for themselves and measure recall
     std::vector<hnswlib::labeltype> neighbors(max_elements);
     ParallelFor(0, max_elements, num_threads, [&](size_t row, size_t threadId) {
-        std::priority_queue<std::pair<float, hnswlib::labeltype>> result = alg_hnsw->searchKnn(data + dim * row, 1);
+        HNSWLIB_ASSIGN_VALUE_OR_THROW_IN_TEST(result, alg_hnsw->searchKnn(data + dim * row, 1));
         hnswlib::labeltype label = result.top().second;
         neighbors[row] = label;
     });

examples/cpp/example_multivector_search.cpp

@@ -63,8 +63,9 @@ int main() {
         }
         std::cout << "Query #" << i << "\n";
         hnswlib::MultiVectorSearchStopCondition<docidtype, dist_t> stop_condition(space, num_docs, ef_collection);
-        std::vector<std::pair<float, hnswlib::labeltype>> result = 
-            alg_hnsw->searchStopConditionClosest(query_data, stop_condition);
+        HNSWLIB_ASSIGN_VALUE_OR_THROW_IN_TEST(
+            result,
+            alg_hnsw->searchStopConditionClosest(query_data, stop_condition));
         size_t num_vectors = result.size();
 
         std::unordered_map<docidtype, size_t> doc_counter;

examples/cpp/example_search.cpp

@@ -29,7 +29,7 @@ int main() {
     // Query the elements for themselves and measure recall
     float correct = 0;
     for (int i = 0; i < max_elements; i++) {
-        std::priority_queue<std::pair<float, hnswlib::labeltype>> result = alg_hnsw->searchKnn(data + i * dim, 1);
+        HNSWLIB_ASSIGN_VALUE_OR_THROW_IN_TEST(result, alg_hnsw->searchKnn(data + i * dim, 1));
         hnswlib::labeltype label = result.top().second;
         if (label == i) correct++;
     }
@@ -45,7 +45,7 @@ int main() {
     alg_hnsw = new hnswlib::HierarchicalNSW<float>(&space, hnsw_path);
     correct = 0;
     for (int i = 0; i < max_elements; i++) {
-        std::priority_queue<std::pair<float, hnswlib::labeltype>> result = alg_hnsw->searchKnn(data + i * dim, 1);
+        HNSWLIB_ASSIGN_VALUE_OR_THROW_IN_TEST(result, alg_hnsw->searchKnn(data + i * dim, 1));
         hnswlib::labeltype label = result.top().second;
         if (label == i) correct++;
     }

hnswlib/bruteforce.h

@@ -1,4 +1,7 @@
 #pragma once
+
+#include "hnswlib.h"
+
 #include <unordered_map>
 #include <fstream>
 #include <mutex>
@@ -61,7 +64,7 @@ class BruteforceSearch : public AlgorithmInterface<dist_t> {
     }
 
 
-    void addPoint(const void *datapoint, labeltype label, bool replace_deleted = false) {
+    HNSWLIB_STATUS_TYPE addPoint(const void *datapoint, labeltype label, bool replace_deleted = false) override {
         int idx;
         {
             std::unique_lock<std::mutex> lock(index_lock);
@@ -103,8 +106,9 @@ class BruteforceSearch : public AlgorithmInterface<dist_t> {
     }
 
 
-    std::priority_queue<std::pair<dist_t, labeltype >>
-    searchKnn(const void *query_data, size_t k, BaseFilterFunctor* isIdAllowed = nullptr) const {
+    using DistanceLabelPriorityQueue = typename AlgorithmInterface<dist_t>::DistanceLabelPriorityQueue;
+    HNSWLIB_STATUS_OR_TYPE(DistanceLabelPriorityQueue)
+    searchKnn(const void *query_data, size_t k, BaseFilterFunctor* isIdAllowed = nullptr) const override {
         assert(k <= cur_element_count);
         std::priority_queue<std::pair<dist_t, labeltype >> topResults;
         if (cur_element_count == 0) return topResults;