add option for warning popups

Author: nmwsharp

include/polyscope/options.h

@@ -69,6 +69,9 @@ extern bool hideWindowAfterShow;
 // Give warnings for inf/nan values
 extern bool warnForInvalidValues;
 
+// Show warnings/errors in popup modal dialogs
+extern bool displayMessagePopups;
+
 // === Scene options
 
 // Behavior of the ground plane

src/messages.cpp

@@ -234,7 +234,7 @@ void terminatingError(std::string message) {
   }
 
   // Enter a modal UI loop showing the warning
-  if (!isHeadless()) { // don't do it if running headless
+  if (options::displayMessagePopups && !isHeadless()) {
     auto func = std::bind(buildErrorUI, message, true);
     pushContext(func, false);
   }
@@ -279,7 +279,7 @@ void showDelayedWarnings() {
     WarningMessage& currMessage = warningMessages.front();
 
     // Enter a modal UI loop showing the warning
-    if (!isHeadless()) { // don't do it if running headless
+    if (options::displayMessagePopups && !isHeadless()) {
       auto func =
           std::bind(buildWarningUI, currMessage.baseMessage, currMessage.detailMessage, currMessage.repeatCount);
       pushContext(func, false);

src/options.cpp

@@ -24,6 +24,7 @@ bool invokeUserCallbackForNestedShow = false;
 bool giveFocusOnShow = false;
 bool hideWindowAfterShow = true;
 bool warnForInvalidValues = true;
+bool displayMessagePopups = true;
 
 bool screenshotTransparency = true;
 std::string screenshotExtension = ".png";

test/include/polyscope_test.h

@@ -32,6 +32,7 @@ class PolyscopeTest : public ::testing::Test {
     polyscope::options::enableRenderErrorChecks = true;
     polyscope::options::errorsThrowExceptions = true;
     polyscope::options::hideWindowAfterShow = false;
+    polyscope::options::displayMessagePopups = false; // these make the tests block otherwise
     polyscope::init(testBackend);
   }