v1.4.2 refactor applyNextPatterns to be able to efficiently handle chord logic in real-time in transport

Author: nnirror

README.md

@@ -342,20 +342,38 @@ You need to connect the MIDI device you want to use before starting Facet.
 	- only play the generated FacetPattern a single time. Without including `once()`, the FacetPattern will regenerate and play back each loop by default.
 	- example:
 		- `$('example').noise(4096).play().once();`
+---
+- **over** ( _n_loops_ = 1 )
+	- distributes all the events that a FacetPattern would fire over `n_loops` so the pattern can last any number of loops before regenerating.
+	- works with audio playback, MIDI note/cc/pitchbend, and OSC.
+	- example:
+		- `$('example').randsamp('808').play(_.ramp(0,1,16)).over(ri(1,4)); // random sample played 16 times over 1,2,3 or 4 bars`
+		- `$('example').drunk(2048,0.01).cc().over(128); // drunk walk over 128 bars, creates a drifty process that you can map onto device paramters to slowly randomize something`
 
 ### Methods for setting variables
 This can be useful when you want to access the same pattern across multiple commands.
 
 - **set** ( _name_ )
 	- saves a FacetPattern's data in memory, for reference as a variable in operations. Any FacetPatterns stored via `.set()` will only be stored until the server is closed.
-	- if a pattern stored with `set()` has more than one piece of data in it, the corresponding variable will be an array. If  the pattern has one piece of data in it, the corresponding variable will be a float.
+	- if a pattern stored with `set()` has more than one piece of data in it, the corresponding variable will be an array. If the pattern has one piece of data in it, the corresponding variable will be a float.
 	- **NOTE**: when you run the `.set()` command for the first time after starting the system, if you're also running commands that reference that variable in the same block, for the first evaluation, the variable will have a value of 0 as it has not fully propagated into the variable storage system.
+	- **NOTE**: if you want to set more than one variable, you should run all the `.set()` methods in a single command, so they do not create a race condition for when they are evaluated.
 		- example:
 		-  ```
 		$('example').tri(100).set('abc').sine(abc).play(); // run it all in one command - just remember the first evaluated sine will have a frequency of 0
 
 		$('set_example').noise(32).curve().set('my_var').once(); // first, set the variable here
 		$('example').noise(100).times(my_var).play(); // now, you can use my_var in commands
+
+		// multi-variable example
+		// step 1: initialize the patterns by running this with .once()
+		$('p1').noise(64).scale(ri(0,63),ri(64,127)).prob(rf()).sticky(rf(0.9,1)).round().set('p1').once();
+		$('p2').noise(64).scale(ri(0,63),ri(64,127)).prob(rf()).sticky(rf(0.9,1)).round().set('p2').once();
+		$('p3').noise(64).scale(ri(0,63),ri(64,127)).prob(rf()).sticky(rf(0.9,1)).round().set('p3').once();
+		$('p4').noise(64).scale(ri(0,63),ri(64,127)).prob(rf()).sticky(rf(0.9,1)).round().set('p4').once();
+
+		// step 2: start the process to continually modify some of the values in the d1-d4 patterns, in one command
+		$('example').from(p1).jam(0.1, 10).wrap(0,127).round().set('p1').from(p2).jam(0.1, 10).wrap(0,127).round().set('p2').from(p3).jam(0.1, 10).wrap(0,127).round().set('p3').from(p4).jam(0.1, 10).wrap(0,127).round().set('p4');
 		``` 
 - **inc** ( _name_, _amount_to_add_ = 1 )
 	- increments a variable called `name` by `amount_to_add`. This variable can be used in operations.

js/FacetPattern.js

@@ -46,6 +46,7 @@ class FacetPattern {
     this.pan_mode = 0;
     this.play_once = false;
     this.original_command = '';
+    this.over_n = 1;
     this.osc_data = [];
     this.pitchbend_data = [];
     this.saveas_filename = false;
@@ -1489,20 +1490,14 @@ waveformSample(waveform, phase) {
     prob = Number(prob);
     let jammed_sequence = [];
     for (const [key, step] of Object.entries(this.data)) {
-      if ( step != 0 ) {
-        if ( Math.random() < prob) {
-          // changed
-          let step_distance = Math.random() * amt;
-          // half the time make it smaller
-          if ( Math.random() < 0.5 ) {
-            step_distance *= -1;
-          }
-          jammed_sequence[key] = Number((Number(step) + Number(step_distance)));
-        }
-        else {
-          // unchanged
-          jammed_sequence[key] = step;
+      if ( Math.random() < prob) {
+        // changed
+        let step_distance = Math.random() * amt;
+        // half the time make it smaller
+        if ( Math.random() < 0.5 ) {
+          step_distance *= -1;
         }
+        jammed_sequence[key] = Number((Number(step) + Number(step_distance)));
       }
       else {
         // unchanged
@@ -2257,11 +2252,13 @@ scaleLT1 (outMin, outMax, exponent = 1) {
     return this;
   }
 
+  over (n = 1) {
+    this.over_n = n;
+    this.whenmod(n);
+    return this;
+  }
+
   whenmod (modulo, equals_value = 0) {
-    let current_bar_number = this.getBars();
-    if  ((current_bar_number-1) % modulo !== equals_value) {
-      this.skipped = true;
-    }
     this.whenmod_modulo_operand = modulo;
     this.whenmod_equals = equals_value;
     return this;

js/pattern_generator.js

@@ -367,19 +367,6 @@ function postMetaDataToTransport (fp,data_type) {
   });
 }
 
-function sliceEndFade(array) {
-  if ( array.length < 1024 ) {
-    return array;
-  }
-  let result = [...array];
-  let fadeLength = 128;
-  for (let i = array.length - fadeLength; i < array.length; i++) {
-    let t = (i - (array.length - fadeLength)) / fadeLength;
-    result[i] = array[i] * (1 - t);
-  }
-  return result;
-}
-
 function panning(input_value, input_channel, total_channels, pan_mode) {
   let fade_range = 2 / total_channels;
   let channel_start = (input_channel * fade_range) - 1;