[TEST] Add test case for lxm service internal API

- Added positive and negative TCs for lxm service internal API

Signed-off-by: hyunil park <hyunil46.park@samsung.com>

Author: songgot

c/include/ml-lxm-service-internal.h

@@ -34,27 +34,24 @@
  *
  * Basic usage workflow:
  * @code
- * // 1. Create session
+ * // 1. Create session with callback
  * ml_lxm_session_h session;
- * ml_lxm_session_create("/path/to/config.json", NULL, &session);
+ * ml_lxm_session_create("/path/to/config.json", NULL, token_handler, NULL, &session);
  *
  * // 2. Create prompt
  * ml_lxm_prompt_h prompt;
  * ml_lxm_prompt_create(&prompt);
  * ml_lxm_prompt_append_text(prompt, "Hello AI");
  *
- * // 3. Set callback using ml_lxm_session_set_event_cb
- * ml_lxm_session_set_event_cb(session, token_handler, NULL);
- *
- * // 4. Generate response with options
+ * // 3. Generate response with options (callback is already set during session creation)
  * ml_option_h options = NULL;
  * ml_option_create(&options);
  * ml_option_set(options, "temperature", g_strdup_printf("%f", 1.0), g_free);
  * ml_option_set(options, "max_tokens", g_strdup_printf("%zu", (size_t)50), g_free);
  * ml_lxm_session_respond(session, prompt, options);
  * ml_option_destroy(options);
  *
- * // 5. Cleanup
+ * // 4. Cleanup
  * ml_lxm_prompt_destroy(prompt);
  * ml_lxm_session_destroy(session);
  * @endcode
@@ -81,8 +78,8 @@
  *     return -1;
  *   }
  *
- *   // 1. Create session with config and instructions
- *   ret = ml_lxm_session_create("/path/to/config.json", "You are a helpful AI assistant", &session);
+ *   // 1. Create session with config, instructions, and callback
+ *   ret = ml_lxm_session_create("/path/to/config.json", "You are a helpful AI assistant", token_handler, NULL, &session);
  *   if (ret != ML_ERROR_NONE) {
  *     std::cout << "Failed to create session" << std::endl;
  *     return -1;
@@ -105,16 +102,7 @@
  *     return -1;
  *   }
  *
- *   // 3. Set callback using ml_lxm_session_set_event_cb
- *   ret = ml_lxm_session_set_event_cb(session, token_handler, NULL);
- *   if (ret != ML_ERROR_NONE) {
- *     std::cout << "Failed to set callback" << std::endl;
- *     ml_lxm_prompt_destroy(prompt);
- *     ml_lxm_session_destroy(session);
- *     return -1;
- *   }
- *
- *   // 4. Generate response with custom options
+ *   // 3. Generate response with custom options
  *   ml_option_h options = NULL;
  *   ml_option_create(&options);
  *   ml_option_set(options, "temperature", g_strdup_printf("%f", 1.2), g_free);
@@ -128,7 +116,7 @@
  *   }
  *   std::cout << std::endl;
  *
- *   // 5. Cleanup
+ *   // 4. Cleanup
  *   ml_lxm_prompt_destroy(prompt);
  *   ml_lxm_session_destroy(session);
  *
@@ -198,13 +186,16 @@ int ml_lxm_check_availability (ml_lxm_availability_e * status);
 typedef void *ml_lxm_session_h;
 
 /**
- * @brief Creates an LXM session.
+ * @brief Creates an LXM session with mandatory callback.
  * @param[in] config_path Path to configuration file.
  * @param[in] instructions Initial instructions (optional).
+ * @param[in] callback Callback function for session events (mandatory).
+ * @param[in] user_data User data to be passed to the callback.
  * @param[out] session Session handle.
  * @return ML_ERROR_NONE on success.
+ * @note The callback parameter is mandatory and will be set during session creation.
  */
-int ml_lxm_session_create (const char *config_path, const char *instructions, ml_lxm_session_h * session);
+int ml_lxm_session_create (const char *config_path, const char *instructions, ml_service_event_cb callback, void *user_data, ml_lxm_session_h * session);
 
 /**
  * @brief Destroys an LXM session.
@@ -256,15 +247,6 @@ int ml_lxm_prompt_destroy (ml_lxm_prompt_h prompt);
  */
 int ml_lxm_session_set_instructions (ml_lxm_session_h session, const char *instructions);
 
-/**
- * @brief Sets the callback for LXM session events.
- * @param[in] session Session handle.
- * @param[in] callback Callback function for session events.
- * @param[in] user_data User data to be passed to the callback.
- * @return ML_ERROR_NONE on success.
- * @note This function should be called once per session. Calling it multiple times will return an error.
- */
-int ml_lxm_session_set_event_cb (ml_lxm_session_h session, ml_service_event_cb callback, void *user_data);
 
 /**
  * @brief Generates an token-streamed response.

c/src/ml-lxm-service.c

@@ -21,11 +21,8 @@ typedef struct
   ml_service_h service_handle;
   char *config_path;
   char *instructions;
-
-  /* Callback related fields */
   ml_service_event_cb user_callback;  /**< User callback function */
   void *user_data;                   /**< User data passed to callback */
-  gboolean callback_set;             /**< Flag indicating if callback is set */
 } ml_lxm_session_internal;
 
 /**
@@ -50,21 +47,24 @@ ml_lxm_check_availability (ml_lxm_availability_e * status)
 }
 
 /**
- * @brief Creates an LXM session.
+ * @brief Creates an LXM session with mandatory callback.
  * @param[in] config_path Path to configuration file.
  * @param[in] instructions Initial instructions (optional).
+ * @param[in] callback Callback function for session events (mandatory).
+ * @param[in] user_data User data to be passed to the callback.
  * @param[out] session Session handle.
  * @return ML_ERROR_NONE on success.
+ * @note The callback parameter is mandatory and will be set during session creation.
  */
 int
 ml_lxm_session_create (const char *config_path, const char *instructions,
-    ml_lxm_session_h * session)
+    ml_service_event_cb callback, void *user_data, ml_lxm_session_h * session)
 {
   ml_service_h handle;
   ml_lxm_session_internal *s;
   int ret;
 
-  if (!session || !config_path)
+  if (!session || !config_path || !callback)
     return ML_ERROR_INVALID_PARAMETER;
 
   ret = ml_service_new (config_path, &handle);
@@ -81,49 +81,24 @@ ml_lxm_session_create (const char *config_path, const char *instructions,
   s->config_path = g_strdup (config_path);
   s->instructions = g_strdup (instructions);
   s->service_handle = handle;
-
-  /* Initialize callback related fields */
-  s->user_callback = NULL;
-  s->user_data = NULL;
-  s->callback_set = FALSE;
-
-  *session = s;
-
-  return ML_ERROR_NONE;
-}
-
-/**
- * @brief Sets the callback for LXM session events.
- * @param[in] session Session handle.
- * @param[in] callback Callback function for session events.
- * @param[in] user_data User data to be passed to the callback.
- * @return ML_ERROR_NONE on success.
- * @note This function should be called once per session. Calling it multiple times will return an error.
- */
-int
-ml_lxm_session_set_event_cb (ml_lxm_session_h session,
-    ml_service_event_cb callback, void *user_data)
-{
-  ml_lxm_session_internal *s;
-  int ret;
-
-  if (!session || !callback)
-    return ML_ERROR_INVALID_PARAMETER;
-
-  s = (ml_lxm_session_internal *) session;
-
-  if (s->callback_set)
-    return ML_ERROR_INVALID_PARAMETER;
+  s->user_callback = callback;
+  s->user_data = user_data;
 
   ret = ml_service_set_event_cb (s->service_handle, callback, user_data);
-  if (ret != ML_ERROR_NONE)
+  if (ret != ML_ERROR_NONE) {
+    /* Cleanup on failure */
+    ml_service_destroy (s->service_handle);
+    g_free (s->config_path);
+    g_free (s->instructions);
+    g_free (s);
     return ret;
+  }
 
-  s->callback_set = TRUE;
-
+  *session = s;
   return ML_ERROR_NONE;
 }
 
+
 /**
  * @brief Destroys an LXM session.
  * @param[in] session Session handle.
@@ -252,7 +227,7 @@ ml_lxm_session_set_instructions (ml_lxm_session_h session,
  * @param[in] prompt Prompt handle.
  * @param[in] options Generation parameters (ml_option_h).
  * @return ML_ERROR_NONE on success.
- * @note The callback should be set using ml_service_set_event_cb() before calling this function.
+ * @note The callback is automatically set during session creation.
  */
 int
 ml_lxm_session_respond (ml_lxm_session_h session,
@@ -271,10 +246,6 @@ ml_lxm_session_respond (ml_lxm_session_h session,
   s = (ml_lxm_session_internal *) session;
   p = (ml_lxm_prompt_internal *) prompt;
 
-  /* Check if callback is set */
-  if (!s->callback_set)
-    return ML_ERROR_STREAMS_PIPE;
-
   full_input = g_string_new ("");
   if (s->instructions && s->instructions[0] != '\0') {
     g_string_append (full_input, s->instructions);

tests/capi/meson.build

@@ -76,6 +76,22 @@ if get_option('enable-ml-service')
       test('unittest_capi_service_training_offloading', unittest_capi_service_training_offloading, env: testenv, timeout: 100)
     endif
   endif
+
+  # LXM Service Tests
+  # These tests require both ml-service and llamacpp to be enabled.
+  llamacpp_dep = dependency('llama', required: false)
+  if llamacpp_dep.found()
+    # Note: The source file itself is also conditionally compiled with ENABLE_LLAMACPP.
+    unittest_capi_lxm_service = executable('unittest_capi_lxm_service',
+      'unittest_capi_lxm_service.cc',
+      dependencies: service_unittest_deps,
+      install: get_option('install-test'),
+      install_dir: unittest_install_dir
+    )
+    test('unittest_capi_lxm_service', unittest_capi_lxm_service, env: testenv, timeout: 120) # Increased timeout for LLM response
+  else
+    message('LXM Service tests will be skipped because llama dependency was not found.')
+  endif
 endif
 
 if nnfw_dep.found()