Source fringe is not removed when org-indent-mode is not used

[nobiot]

To reproduce:

1. Ensure org-indent-mode and org-transclusion-indent-mode are inactive for both transcluding and source buffers.
2. Add an org transclusion (source fringe is added as expected).
3. Remove the transclusion (source fringe remains).

I have tested with an Org file as a source mainly, but I observe the same issue when the source is non-Org file (txt).

@gggion , I will appreciate it if you can have a look. Thank you.

[nobiot]

Please look at feat/transient branch. I believe 206aadb fixes the issue for non-Org sources.

For Org sources, I don't think function org-transclusion-remove-fringe-from-prefix is doing what the function documentation says it does... (It does not seem to be doing anything).

[nobiot]

In the same feature branch feat/transient, I have done commit 4f47a15 for Org files. I have also done a regression test; Org-indent mode together with Org-transclusion-indent-mode seem to work as well.

Can you also test the terminal works OK? I only tested graphical interface.

On a side note, I feel fringe management is a bit overly complicated... I wonder if there were any simpler approach.

[gggion]

Noted, I'll take a look this sunday.
yeah I agree with fringe management being too complicated.
it grew into that over time while I was trying to solve fringes being lost to org-indent-mode-agent timings, plus some wrong initial assumptions.

I think it can be refactored into a much simpler and straightforward system, maybe fringe-apply and fringe-remove, will look into it this week 👍

[nobiot]

Thank you!

[gggion]

Looking into refactoring the fringe management right now (in transient branch)
as a sidenote tested the current state of the transient branch with terminal display:

Tested doom emacs and vanilla:

• normal org-mode
• org-modern
• org-modern + org-modern-indent

no issues detected, fringes are placed, removed and indentation is preserved through buffer refresh when using terminal display.

[nobiot]

Thank you. Okay, so I will try to merge the feature branch to main once I have done documentation, while you work on refactoring in parallel.

[gggion]

Yeah, I'll track progress in #284